Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solid sticky collection decorators #1336

Merged

Conversation

victornoel
Copy link
Collaborator

This is for #1302 and #1295.

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2020

@paulodamaso/z everybody who has role REV is banned at #1336; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@victornoel
Copy link
Collaborator Author

@paulodamaso ping

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2020

This pull request #1336 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Copy link
Contributor

@marceloamadeu marceloamadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso looks good to merge.

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 3, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 443f7b2 into yegor256:master Apr 3, 2020
@rultor
Copy link
Collaborator

rultor commented Apr 3, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 12min)

@0crat
Copy link
Collaborator

0crat commented Apr 3, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 11@b709309d79e4, thread: PQ-C63314D6Z
com.zerocracy.farm.ruled.RdRules[130] java.lang.IllegalStateException: http://datum.zerocracy.com/latest/rules/pm/no-lost-boosts.xsl says: The boost for job "gh:yegor256/cactoos#1336" exists in boosts.xml, but the job is absent in the WBS among 33 jobs.

0.52.15: CID: 43f73d1c-85b6-48bd-bf67-80bd166a7425, Type: "Remove job from WBS"

@0crat 0crat added the qa label Apr 3, 2020
@victornoel victornoel deleted the remove-solid-sticky-collection-decorators branch April 3, 2020 12:29
@0crat
Copy link
Collaborator

0crat commented Apr 3, 2020

@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Apr 3, 2020

Job was finished in 23 hours, bonus for fast delivery is possible (see §36)

@sereshqua
Copy link

@0crat quality bad

@0crat 0crat added quality/bad and removed qa labels Apr 3, 2020
@0crat
Copy link
Collaborator

0crat commented Apr 3, 2020

Quality is low, no payment, see §31

@0crat 0crat removed the scope label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants