Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1337: Tests Iterator Reverse #1361

Merged
merged 1 commit into from
Apr 30, 2020
Merged

#1337: Tests Iterator Reverse #1361

merged 1 commit into from
Apr 30, 2020

Conversation

marceloamadeu
Copy link
Contributor

This PR is for #1337

@0crat
Copy link
Collaborator

0crat commented Apr 29, 2020

This pull request #1361 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marceloamadeu here is one comment for now

)
),
new IsEqual<>(
new ListOf<>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marceloamadeu can't we directly compare iterators? or maybe use an existing matcher that allows to compare iterator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel I couldn't find another way to resolve it. Do you have any suggestion?
Thank!!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marceloamadeu let's forget about it, thank you for trying :)

@victornoel
Copy link
Collaborator

@paulodamaso good to merge

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 30, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 598bb91 into yegor256:master Apr 30, 2020
@rultor
Copy link
Collaborator

rultor commented Apr 30, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 8min)

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2020

Job was finished in 33 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat added qa and removed scope labels Apr 30, 2020
@0crat
Copy link
Collaborator

0crat commented Apr 30, 2020

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@victornoel please make sure you will find at least 3 issues during next CR, thanks :)

@victornoel
Copy link
Collaborator

@sereshqua yes, thx

@sereshqua
Copy link

@0crat quality acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants