#1367: Scalar - Replacing usage of MatcherAssert.assertThat #1371
Conversation
marceloamadeu
changed the title
|
This pull request #1371 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
There was a problem hiding this comment.
@marceloamadeu I've left some comments. I realise this would mean change a lot of things that are not really related to the todo you are solving, but still I think it's a good idea to do it. So maybe do some of them and add a todo in package-info.java to finish replacing all the IsEqual with ScalarHasValue?
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=========================================
Coverage 89.66% 89.66%
Complexity 1662 1662
=========================================
Files 274 274
Lines 3948 3948
Branches 211 211
=========================================
Hits 3540 3540
Misses 375 375
Partials 33 33 Continue to review full report at Codecov.
|
|
@victornoel |
|
@marceloamadeu very nice, thank you! @paulodamaso looks good to me |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 8min) |
|
@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality good |
This PR is for #1367