Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #1346: forcing delete of settings.xml at the end of merging #1380

Merged
merged 1 commit into from
May 6, 2020

Conversation

paulodamaso
Copy link
Contributor

For #1346: forcing delete of settings.xml at the end of merging

@paulodamaso
Copy link
Contributor Author

@rultor merge

@0crat
Copy link
Collaborator

0crat commented May 6, 2020

@paulodamaso/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

@rultor
Copy link
Collaborator

rultor commented May 6, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8fcab6c into yegor256:master May 6, 2020
@rultor
Copy link
Collaborator

rultor commented May 6, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 8min)

@0crat
Copy link
Collaborator

0crat commented May 6, 2020

Job gh:yegor256/cactoos#1380 is not assigned, can't get performer

@paulodamaso paulodamaso deleted the 1346-8 branch May 6, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants