#1376: Scalar - Replace all the IsEqual with ScalarHashValue

[marceloamadeu]

This PR is for #1376

[codecov-io]

Codecov Report

Merging #1383 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1383   +/-   ##
=========================================
  Coverage     89.69%   89.69%           
  Complexity     1667     1667           
=========================================
  Files           275      275           
  Lines          3959     3959           
  Branches        211      211           
=========================================
  Hits           3551     3551           
  Misses          375      375           
  Partials         33       33           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c6e9a...aa3d431. Read the comment docs.

[marceloamadeu]

#1367 was removed because I didn't find any more cases of IsEqual that should be exchanged for ScalarHashValue.

To confirm, can you tell if in this case it is possible to use ScalarHashValue?

    public void dividesIntNumbers() {
        new Assertion<>(
            "Must divide int numbers",
            new DivisionOf(4, 2).intValue(),
            new IsEqual<>(2)
        ).affirm();
    }

Tks

[0crat]

This pull request #1383 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[victornoel]

@marceloamadeu just one comment to ensure all is well in terms of todos :)

[victornoel]

@marceloamadeu have you verified there is really no IsEqual incorrectly used in the tests of scalar package?

[victornoel]

@marceloamadeu indeed, it seems to be ok then, thanks

@paulodamaso looks good to me

[paulodamaso]

@rultor merge

[rultor]

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 8min)

[0crat]

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@victornoel please make sure you will find at least 3 issues during next CR, thanks

[victornoel]

@sereshqua yes ^^ it's quite hard with this kind of PR :)

[sereshqua]

@0crat quality acceptable