Remove some more MatcherAssert #1393
Conversation
|
This pull request #1393 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
| MatcherAssert.assertThat( | ||
| "IOException class is not supported, but should be", | ||
| new Assertion<>( | ||
| "Must support IOException class", | ||
| new FallbackFrom<>( | ||
| new IterableOf<>(IOException.class), |
There was a problem hiding this comment.
@victornoel error log: unchecked generic array creation for varargs parameter of type java.lang.Class<? extends java.lang.Throwable>[]
| MatcherAssert.assertThat( | ||
| "RuntimeException class is not supported, but should be", | ||
| new Assertion<>( | ||
| "Must support RuntimeException class", | ||
| new FallbackFrom<>( | ||
| new IterableOf<>(RuntimeException.class), |
There was a problem hiding this comment.
@victornoel error log: unchecked generic array creation for varargs parameter of type java.lang.Class<? extends java.lang.Throwable>[]
| MatcherAssert.assertThat( | ||
| "RuntimeException class is supported, but should not be", | ||
| new Assertion<>( | ||
| "Must support RuntimeException class", | ||
| new FallbackFrom<>( | ||
| new IterableOf<>(RuntimeException.class), |
There was a problem hiding this comment.
@victornoel error log: unchecked generic array creation for varargs parameter of type java.lang.Class<? extends java.lang.Throwable>[]
|
@marceloamadeu it is fixed, also there were some other qulice errors now fixed |
Codecov Report
@@ Coverage Diff @@
## master #1393 +/- ##
============================================
- Coverage 89.69% 89.66% -0.03%
+ Complexity 1667 1666 -1
============================================
Files 275 275
Lines 3959 3959
Branches 211 211
============================================
- Hits 3551 3550 -1
Misses 376 376
- Partials 32 33 +1
Continue to review full report at Codecov.
|
|
@paulodamaso ping |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 10min) |
|
@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality good |
This is for #1391.