For #1277: Add RepeatedProc #1399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
============================================
+ Coverage 89.80% 89.81% +0.01%
- Complexity 1686 1688 +2
============================================
Files 275 276 +1
Lines 4000 4006 +6
Branches 211 211
============================================
+ Hits 3592 3598 +6
Misses 376 376
Partials 32 32
Continue to review full report at Codecov.
|
|
This pull request #1399 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
|
@paulodamaso looks good to me |
|
@andreoss Please correct:
|
@marceloamadeu Done |
|
@paulodamaso ping |
|
|
||
| /** | ||
| * Proc that repeats its calculation a few times before | ||
| * returning the last result. |
There was a problem hiding this comment.
@andreoss a Proc does not return any result, can you fix this javadoc?
There was a problem hiding this comment.
@andreoss it seems you added an unwanted class and also the build is broken
| import java.nio.file.Paths; | ||
|
|
||
|
|
||
| public class XsltTransformer { |
There was a problem hiding this comment.
@andreoss you incorrectly added this class apparently, can you remove it?
|
@andreoss Please... check Travis CI build failure. |
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 10min) |
|
Code review was too long (18 days), architects (@paulodamaso, @victornoel/z) were penalized, see §55 |
For #1277
Introduced
RepeatedProc