Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1335) LengthOf is now just a Scalar of Long #1535

Closed
wants to merge 1 commit into from

Conversation

victornoel
Copy link
Collaborator

First step of #1335: LengthOf is not a Number anymore

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

This pull request #1535 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator Author

@baudoliver7 We need to wait for llorllale/cactoos-matchers#221 and then #1531 for this to be able to build. I will ping you back when it's ok :)

@baudoliver7
Copy link
Contributor

@victornoel Ok

@victornoel victornoel marked this pull request as draft January 17, 2021 16:56
@baudoliver7
Copy link
Contributor

@victornoel I'm always waiting :)

@victornoel
Copy link
Collaborator Author

@baudoliver7 I know, I haven't forgot, this nor any of the other opened PRs

@baudoliver7
Copy link
Contributor

@victornoel Just to remind you that if code review takes too long time, you will be exposed to penalties as ARC §55

@victornoel
Copy link
Collaborator Author

@0crat refuse

@victornoel
Copy link
Collaborator Author

victornoel commented Jan 30, 2021

@baudoliver7 I know, if I were paid, maybe I would worry about it :) I've removed you from this job and will add you again once it's ready to be reviewed. I am waiting for another ticket to be solved first

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2021

@0crat refuse (here)

@victornoel The user @baudoliver7/z resigned from #1535, please stop working. Reason for job resignation: Order was cancelled

@baudoliver7
Copy link
Contributor

@victornoel Good ! Don't hesitate to assign it to me again when all things are ready :)

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2021

@victornoel/z everybody who has role REV is banned at #1535; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Feb 4, 2021

@victornoel/z everybody who has role REV is banned at #1535; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@victornoel
Copy link
Collaborator Author

Closing this, even with #1531 it's not building, we will have to wait for llorllale/cactoos-matchers#220 to be fixed first

@victornoel victornoel closed this Feb 6, 2021
@0crat
Copy link
Collaborator

0crat commented Feb 6, 2021

Job gh:yegor256/cactoos#1535 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Feb 6, 2021
@0crat
Copy link
Collaborator

0crat commented Feb 6, 2021

Pull request #1535 was not merged, no payment for ARC, see §28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants