-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1335) LengthOf is now just a Scalar of Long #1535
Conversation
This pull request #1535 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@baudoliver7 We need to wait for llorllale/cactoos-matchers#221 and then #1531 for this to be able to build. I will ping you back when it's ok :) |
@victornoel Ok |
@victornoel I'm always waiting :) |
@baudoliver7 I know, I haven't forgot, this nor any of the other opened PRs |
@victornoel Just to remind you that if code review takes too long time, you will be exposed to penalties as ARC §55 |
@0crat refuse |
@baudoliver7 I know, if I were paid, maybe I would worry about it :) I've removed you from this job and will add you again once it's ready to be reviewed. I am waiting for another ticket to be solved first |
@victornoel The user @baudoliver7/z resigned from #1535, please stop working. Reason for job resignation: Order was cancelled |
@victornoel Good ! Don't hesitate to assign it to me again when all things are ready :) |
Closing this, even with #1531 it's not building, we will have to wait for llorllale/cactoos-matchers#220 to be fixed first |
Job |
First step of #1335: LengthOf is not a Number anymore