(#1254) Implements ListIteratorJoined

[baudoliver7]

For #1254

• Implements JoinedListIterator
• Introduces unit tests for JoinedListIterator

[0crat]

@victornoel/z everybody who has role REV is banned at #1548; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[victornoel]

@baudoliver7 on top of the comment, I propose to have all the mutable operations (I think remove, set and add) throw UnssuportedOperationException and add a todo to think about a smart solution to implement them. Because for now I'm not comfortable with the proposed implementation, it seems fragile to rely on emptyListIterator like this... The todo should clearly state that the javadoc of those operations should be well respected and also that the behaviour of adding/setting/removing an element when the cursor is in between two listiterators be well documented in this class (because there are multiple options in that case, no?).
Alternatively, we keep them, use hasPrevious/hasNext instead of checking the empty list iterator and add a todo to clarify doc and ensure the implementation is correct as explained above.

[victornoel]

@baudoliver7 hi, how is it going for this PR? :)

[baudoliver7]

@victornoel Please, let's me add some changes and send you them today :) Le sam. 6 mars 2021 à 5:40 PM, Victor Noël <[email protected]> a écrit :

…

@baudoliver7 <https://github.com/baudoliver7> hi, how is it going for this PR? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1548 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3TPNWD6F7VFFWEWCLVQIDTCJSIJANCNFSM4YILVFTA> .

[victornoel]

@baudoliver7 no rush, I mostly wanted to be sure it wasn't forgotten :)

[baudoliver7]

@victornoel Please, could you have a look at my new changes ?

[victornoel]

@baudoliver7 thx

[victornoel]

@rultor merge

[rultor]

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

[0crat]

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@0crat quality bad

[0crat]

Quality is low, no payment, see §31