-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1572) Ensure generic variance org.cactoos.func package #1605
Conversation
@DmitryBarskov this pull request is too small, just 3 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @victornoel/z please review this and merge or reject |
@rultor merge |
@rultor stop |
@DmitryBarskov The func package seems to contain a lot of things to update, see #1533 for details |
@DmitryBarskov btw you dont have to do everything of course, just do a subset and update the todo for another task to be created to continue the work |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel OK, I'll try to stop current task. |
@DmitryBarskov @victornoel Sorry, I failed to stop the previous command, however it has the following result: Oops, I failed. You can see the full log here (spent 2min)
|
@DmitryBarskov I will close this and let you recreate a new one with some changes :) |
Job |
For #1572
With especial attention to
Func
andChained
this package looks good for me.