Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1572) Ensure generic variance org.cactoos.func package #1605

Closed
wants to merge 1 commit into from

Conversation

DmitryBarskov
Copy link
Contributor

For #1572

  • Remove puzzle from org.cactoos.func package

With especial attention to Func and Chained this package looks good for me.

@0crat
Copy link
Collaborator

0crat commented May 7, 2021

@DmitryBarskov this pull request is too small, just 3 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @victornoel/z please review this and merge or reject

@victornoel
Copy link
Collaborator

@rultor merge

@victornoel
Copy link
Collaborator

@rultor stop

@victornoel
Copy link
Collaborator

@DmitryBarskov The func package seems to contain a lot of things to update, see #1533 for details

@victornoel
Copy link
Collaborator

@DmitryBarskov btw you dont have to do everything of course, just do a subset and update the todo for another task to be created to continue the work

@rultor
Copy link
Collaborator

rultor commented May 7, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 7, 2021

@rultor stop

@victornoel OK, I'll try to stop current task.

@rultor
Copy link
Collaborator

rultor commented May 7, 2021

@rultor stop

@DmitryBarskov @victornoel Sorry, I failed to stop the previous command, however it has the following result: Oops, I failed. You can see the full log here (spent 2min)

Progress (1): 1.9 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-repository-metadata/3.0/maven-repository-metadata-3.0.pom (1.9 kB at 8.2 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-model-builder/3.0/maven-model-builder-3.0.pom
Progress (1): 2.2 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-model-builder/3.0/maven-model-builder-3.0.pom (2.2 kB at 10.0 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-aether-provider/3.0/maven-aether-provider-3.0.pom
Progress (1): 2.5 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-aether-provider/3.0/maven-aether-provider-3.0.pom (2.5 kB at 9.9 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-api/1.7/aether-api-1.7.pom
Progress (1): 1.7 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-api/1.7/aether-api-1.7.pom (1.7 kB at 7.4 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-parent/1.7/aether-parent-1.7.pom
Progress (1): 4.1/7.7 kB
Progress (1): 7.7 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-parent/1.7/aether-parent-1.7.pom (7.7 kB at 34 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-util/1.7/aether-util-1.7.pom
Progress (1): 2.1 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-util/1.7/aether-util-1.7.pom (2.1 kB at 9.2 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-impl/1.7/aether-impl-1.7.pom
Progress (1): 3.7 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-impl/1.7/aether-impl-1.7.pom (3.7 kB at 16 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-spi/1.7/aether-spi-1.7.pom
Progress (1): 1.7 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/sonatype/aether/aether-spi/1.7/aether-spi-1.7.pom (1.7 kB at 7.6 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/enforcer/enforcer-api/3.0.0-M3/enforcer-api-3.0.0-M3.pom
Progress (1): 2.8 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/enforcer/enforcer-api/3.0.0-M3/enforcer-api-3.0.0-M3.pom (2.8 kB at 12 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-container-default/1.0-alpha-9/plexus-container-default-1.0-alpha-9.pom
Progress (1): 1.2 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-container-default/1.0-alpha-9/plexus-container-default-1.0-alpha-9.pom (1.2 kB at 5.4 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-containers/1.0.3/plexus-containers-1.0.3.pom
Progress (1): 492 B
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-containers/1.0.3/plexus-containers-1.0.3.pom (492 B at 2.2 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus/1.0.4/plexus-1.0.4.pom
Progress (1): 4.1/5.7 kB
Progress (1): 5.7 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus/1.0.4/plexus-1.0.4.pom (5.7 kB at 25 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/junit/junit/4.11/junit-4.11.pom
Progress (1): 2.3 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/junit/junit/4.11/junit-4.11.pom (2.3 kB at 6.2 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.pom
Progress (1): 3.1 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.pom (3.1 kB at 14 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/enforcer/enforcer-rules/3.0.0-M3/enforcer-rules-3.0.0-M3.pom
Progress (1): 4.1/4.1 kB
Progress (1): 4.1 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/enforcer/enforcer-rules/3.0.0-M3/enforcer-rules-3.0.0-M3.pom (4.1 kB at 18 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-common-artifact-filters/3.1.0/maven-common-artifact-filters-3.1.0.pom
Progress (1): 4.1/5.3 kB
Progress (1): 5.3 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-common-artifact-filters/3.1.0/maven-common-artifact-filters-3.1.0.pom (5.3 kB at 23 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-components/33/maven-shared-components-33.pom
Progress (1): 4.1/5.1 kB
Progress (1): 5.1 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-components/33/maven-shared-components-33.pom (5.1 kB at 22 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.pom
Progress (1): 4.1/5.0 kB
Progress (1): 5.0 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.pom (5.0 kB at 22 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/commons/commons-lang3/3.8.1/commons-lang3-3.8.1.pom
Progress (1): 4.1/28 kB
Progress (1): 8.2/28 kB
Progress (1): 12/28 kB 
Progress (1): 16/28 kB
Progress (1): 20/28 kB
Progress (1): 25/28 kB
Progress (1): 28 kB   
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/commons/commons-lang3/3.8.1/commons-lang3-3.8.1.pom (28 kB at 117 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/commons/commons-parent/47/commons-parent-47.pom
Progress (1): 4.1/78 kB
Progress (1): 8.2/78 kB
Progress (1): 12/78 kB 
Progress (1): 16/78 kB
Progress (1): 20/78 kB
Progress (1): 25/78 kB
Progress (1): 29/78 kB
Progress (1): 33/78 kB
Progress (1): 37/78 kB
Progress (1): 41/78 kB
Progress (1): 45/78 kB
Progress (1): 49/78 kB
Progress (1): 53/78 kB
Progress (1): 57/78 kB
Progress (1): 61/78 kB
Progress (1): 66/78 kB
Progress (1): 70/78 kB
Progress (1): 74/78 kB
Progress (1): 78 kB   
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/commons/commons-parent/47/commons-parent-47.pom (78 kB at 308 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/commons-codec/commons-codec/1.12/commons-codec-1.12.pom
Progress (1): 4.1/14 kB
Progress (1): 8.2/14 kB
Progress (1): 12/14 kB 
Progress (1): 14 kB   
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/commons-codec/commons-codec/1.12/commons-codec-1.12.pom (14 kB at 58 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/beanshell/bsh/2.0b4/bsh-2.0b4.pom
Progress (1): 1.2 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/beanshell/bsh/2.0b4/bsh-2.0b4.pom (1.2 kB at 5.3 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/beanshell/beanshell/2.0b4/beanshell-2.0b4.pom
Progress (1): 1.4 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/beanshell/beanshell/2.0b4/beanshell-2.0b4.pom (1.4 kB at 6.2 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.pom
Progress (1): 4.1/7.3 kB
Progress (1): 7.3 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.pom (7.3 kB at 32 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-components/20/maven-shared-components-20.pom
Progress (1): 4.1/5.1 kB
Progress (1): 5.1 kB    
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/shared/maven-shared-components/20/maven-shared-components-20.pom (5.1 kB at 22 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-parent/24/maven-parent-24.pom
Progress (1): 4.1/37 kB
Progress (1): 8.2/37 kB
Progress (1): 12/37 kB 
Progress (1): 16/37 kB
Progress (1): 20/37 kB
Progress (1): 25/37 kB
Progress (1): 29/37 kB
Progress (1): 33/37 kB
Progress (1): 37/37 kB
Progress (1): 37 kB   
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/maven-parent/24/maven-parent-24.pom (37 kB at 144 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/apache/14/apache-14.pom
Progress (1): 4.1/15 kB
Progress (1): 8.2/15 kB
Progress (1): 12/15 kB 
Progress (1): 15 kB   
                   
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/apache/14/apache-14.pom (15 kB at 57 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/resolver/maven-resolver-util/1.4.1/maven-resolver-util-1.4.1.pom
Progress (1): 2.8 kB
                    
Downloaded from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/resolver/maven-resolver-util/1.4.1/maven-resolver-util-1.4.1.pom (2.8 kB at 12 kB/s)
Downloading from oss.sonatype.org: https://oss.sonatype.org/content/groups/public/org/apache/maven/resolver/maven-resolver/1.4.1/maven-resolver-1.4.1.pom
60e81de6e3df3b4a2c88c5aa3241b799ab52ea41d1d0c483c6ba0818762a8e15
Error response from daemon: Cannot kill container: 60e81de6e3df3b4a2c88c5aa3241b799ab52ea41d1d0c483c6ba0818762a8e15: Container 60e81de6e3df3b4a2c88c5aa3241b799ab52ea41d1d0c483c6ba0818762a8e15 is not running
container 60e81de6e3df3b4a2c88c5aa3241b799ab52ea41d1d0c483c6ba0818762a8e15 is dead
Fri May  7 13:29:38 CEST 2021

@victornoel
Copy link
Collaborator

@DmitryBarskov I will close this and let you recreate a new one with some changes :)

@victornoel victornoel closed this May 7, 2021
@0crat
Copy link
Collaborator

0crat commented May 7, 2021

Job gh:yegor256/cactoos#1605 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants