-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1566) Generify org.cactoos.list package #1635
(#1566) Generify org.cactoos.list package #1635
Conversation
Hey @victornoel! Could you have a look please? |
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
============================================
+ Coverage 90.10% 90.13% +0.02%
- Complexity 1603 1604 +1
============================================
Files 298 298
Lines 3749 3749
Branches 122 122
============================================
+ Hits 3378 3379 +1
Misses 337 337
+ Partials 34 33 -1
Continue to review full report at Codecov.
|
@victornoel what's up with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitryBarskov late review :)
@@ -47,7 +47,7 @@ | |||
/** | |||
* {@link List} of {@link ListIterator}. | |||
*/ | |||
private final List<ListIterator<T>> listiters; | |||
private final List<ListIterator<? extends T>> listiters; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitryBarskov I think that should be List<? extends ListIterator<...
, here and everywhere else :)
@DmitryBarskov thank you. Did you verify that there was no more class in the |
@victornoel yes, checked it twice |
@DmitryBarskov excellent, thank you very much! |
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 8min) |
For #1566:
Generify some classes in org.cactoos.list package: