Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests migration to JUnit 5 #1713

Merged
merged 8 commits into from
Feb 21, 2024
Merged

tests migration to JUnit 5 #1713

merged 8 commits into from
Feb 21, 2024

Conversation

pnatashap
Copy link
Contributor

  • JUnit 4 is deleted (and from deprecated api, as it fails on missing dependency)
  • Assertions usage is change to cactoos Assertion
  • Some fix to close streams (failed on windows)
  • update actions versions

Fix #1586

@pnatashap
Copy link
Contributor Author

@yegor256 please take a look

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 21, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3150ff1 into yegor256:master Feb 21, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 21, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

@yegor256
Copy link
Owner

@pnatashap thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pom.xml:120-122: Continue migration of tests to JUnit 5....
4 participants
@pnatashap @yegor256 @rultor @0pdd