Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#208: more ctors and classes #212

Merged
merged 3 commits into from
Jun 23, 2017
Merged

#208: more ctors and classes #212

merged 3 commits into from
Jun 23, 2017

Conversation

yegor256
Copy link
Owner

see #208

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #212 into master will increase coverage by 0.08%.
The diff coverage is 62.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     73.26%   73.34%   +0.08%     
- Complexity      336      339       +3     
============================================
  Files           111      113       +2     
  Lines          1036     1043       +7     
  Branches         33       33              
============================================
+ Hits            759      765       +6     
- Misses          264      265       +1     
  Partials         13       13
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/io/LengthOfInput.java 94.11% <ø> (ø) 5 <0> (ø) ⬇️
src/main/java/org/cactoos/io/UncheckedOutput.java 0% <0%> (ø) 0 <0> (?)
src/main/java/org/cactoos/io/InputAsLSInput.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/main/java/org/cactoos/io/UncheckedInput.java 0% <0%> (ø) 0 <0> (?)
...rc/main/java/org/cactoos/io/InputAsProperties.java 92.85% <100%> (+5.35%) 5 <3> (+3) ⬆️
src/main/java/org/cactoos/text/UrlAsString.java 84.61% <100%> (+11.28%) 4 <3> (ø) ⬇️
src/main/java/org/cactoos/text/StringAsUrl.java 84.61% <100%> (+11.28%) 4 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eda619...4a75069. Read the comment docs.

@yegor256
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 23, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4a75069 into master Jun 23, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 23, 2017

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@paulodamaso paulodamaso deleted the 208 branch May 6, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants