Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#251: Let's do ReverseIterableTest use JoinedText #259

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

fabriciofx
Copy link
Contributor

As per #251.

@0crat
Copy link
Collaborator

0crat commented Jun 28, 2017

@fabriciofx I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

@codecov-io
Copy link

codecov-io commented Jun 28, 2017

Codecov Report

Merging #259 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage      73.5%   73.42%   -0.08%     
- Complexity      387      388       +1     
============================================
  Files           124      124              
  Lines          1200     1208       +8     
  Branches         41       41              
============================================
+ Hits            882      887       +5     
- Misses          297      300       +3     
  Partials         21       21
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/text/SplitText.java 64% <0%> (-0.71%) 6% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884896c...c4969c8. Read the comment docs.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 28, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c4969c8 into yegor256:master Jun 28, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 28, 2017

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 15min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants