#378: ReaderOf, InputStreamOf, OutputStreamOf, etc. #379

yegor256 · 2017-08-04T17:31:52Z

see #378. Introduced these classes:

OutputStreamTo
WriterAsOutput
WriterAsOutput
WriterAsOutputStream
WriterTo
ReaderOf

yegor256 · 2017-08-04T17:31:58Z

@rultor merge

0crat · 2017-08-04T17:32:12Z

Job gh:yegor256/cactoos#379 is in scope.

0crat · 2017-08-04T17:32:36Z

+15 points just awarded to @yegor256, total is +1080.

rultor · 2017-08-04T17:33:10Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-08-04T17:38:50Z

@rultor merge

@yegor256 Oops, I failed. You can see the full log here (spent 5min)

     but: was <org.cactoos.text.TextOf@58cfafe3>
  WriterToTest.writesLargeContentToFile:49 Can't copy Input to Output and return Input
Expected: Text with org.cactoos.io.WriterToTest$$Lambda$51/946395166@3462f7de
     but: was <org.cactoos.text.TextOf@bd667cc>

Tests run: 263, Failures: 5, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:45 min
[INFO] Finished at: 2017-08-04T17:37:27+00:00
[INFO] Final Memory: 29M/349M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
	at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:320)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:892)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 40159f41d410a85822c6428725226c46e0a859b075b6937b96564de4c5d1d312 is dead
Fri Aug  4 19:38:31 CEST 2017

codecov-io · 2017-08-04T17:45:49Z

Codecov Report

Merging #379 into master will decrease coverage by 1.97%.
The diff coverage is 53.75%.

@@             Coverage Diff              @@
##             master     #379      +/-   ##
============================================
- Coverage     75.14%   73.16%   -1.98%     
- Complexity      485      516      +31     
============================================
  Files           124      130       +6     
  Lines          1573     1733     +160     
  Branches         73       76       +3     
============================================
+ Hits           1182     1268      +86     
- Misses          371      443      +72     
- Partials         20       22       +2

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/io/BytesOf.java	`88.37% <0%> (-9.07%)`	`18 <0> (ø)`
src/main/java/org/cactoos/io/OutputTo.java	`66.66% <0%> (-13.34%)`	`4 <0> (ø)`
src/main/java/org/cactoos/io/WriterAsOutput.java	`100% <100%> (ø)`	`5 <5> (?)`
src/main/java/org/cactoos/io/ReaderOf.java	`29.41% <29.41%> (ø)`	`5 <5> (?)`
src/main/java/org/cactoos/io/InputStreamOf.java	`38.46% <38.46%> (ø)`	`5 <5> (?)`
src/main/java/org/cactoos/text/TextOf.java	`78.72% <50%> (-2.68%)`	`19 <1> (+1)`
src/main/java/org/cactoos/io/OutputStreamTo.java	`57.89% <57.89%> (ø)`	`5 <5> (?)`
src/main/java/org/cactoos/io/WriterTo.java	`64.7% <64.7%> (ø)`	`5 <5> (?)`
...main/java/org/cactoos/io/WriterAsOutputStream.java	`71.42% <71.42%> (ø)`	`5 <5> (?)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3599ce...1a56fbe. Read the comment docs.

yegor256 · 2017-08-04T17:46:46Z

@rultor merge

rultor · 2017-08-04T17:46:57Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-08-04T17:52:29Z

@rultor merge

@yegor256 Oops, I failed. You can see the full log here (spent 5min)

     but: was <org.cactoos.text.TextOf@6c7afa41>
  WriterToTest.writesLargeContentToFile:49 Can't copy Input to Output and return Input
Expected: Text with org.cactoos.io.WriterToTest$$Lambda$63/2102939128@71873289
     but: was <org.cactoos.text.TextOf@5258d2f>

Tests run: 263, Failures: 4, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:55 min
[INFO] Finished at: 2017-08-04T17:51:27+00:00
[INFO] Final Memory: 29M/379M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
	at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:320)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:892)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 420fec83b38c0e274e343e6f64d90b533c3e73ef81a14f14a6989a7fc9f3553d is dead
Fri Aug  4 19:52:20 CEST 2017

yegor256 · 2017-08-04T17:56:24Z

@rultor merge

rultor · 2017-08-04T17:57:07Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-08-04T18:08:01Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 11min)

0crat · 2017-08-29T14:45:09Z

Job gh:yegor256/cactoos#379 assigned to @kkamkou, please go ahead (policy).

0crat · 2017-11-18T08:30:15Z

@kkamkou resigned from gh:yegor256/cactoos#379, please stop working.

0crat · 2017-11-18T09:49:20Z

Job gh:yegor256/cactoos#379 assigned to @kkamkou, please go ahead (policy).

0crat · 2017-11-23T13:49:18Z

Order was successfully finished: +30 points just awarded to @kkamkou, total is +930.

0crat · 2017-11-23T14:58:53Z

Oops! Job gh:yegor256/cactoos#379 is not in scope

yegor256 added 3 commits August 4, 2017 16:46

#378: ReaderOf

d4afdd0

#378: InputStreamOf

98c7c8f

#378: OutputStreamTo, WriterTo, WriterAsOutput, WriterAsOuputStream

2bc257a

#378: encoding

7aca414

yegor256 added 2 commits August 4, 2017 20:55

#378: encodings fixed

55e6185

#378: encodings fixed more

1a56fbe

rultor merged commit 1a56fbe into master Aug 4, 2017

yegor256 deleted the 378 branch August 4, 2017 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#378: ReaderOf, InputStreamOf, OutputStreamOf, etc. #379

#378: ReaderOf, InputStreamOf, OutputStreamOf, etc. #379

yegor256 commented Aug 4, 2017

yegor256 commented Aug 4, 2017

0crat commented Aug 4, 2017

0crat commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

codecov-io commented Aug 4, 2017 •

edited

Loading

yegor256 commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

yegor256 commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

0crat commented Aug 29, 2017

0crat commented Nov 18, 2017

0crat commented Nov 18, 2017

0crat commented Nov 23, 2017

0crat commented Nov 23, 2017

#378: ReaderOf, InputStreamOf, OutputStreamOf, etc. #379

#378: ReaderOf, InputStreamOf, OutputStreamOf, etc. #379

Conversation

yegor256 commented Aug 4, 2017

yegor256 commented Aug 4, 2017

0crat commented Aug 4, 2017

0crat commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

codecov-io commented Aug 4, 2017 • edited Loading

Codecov Report

yegor256 commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

yegor256 commented Aug 4, 2017

rultor commented Aug 4, 2017

rultor commented Aug 4, 2017

0crat commented Aug 29, 2017

0crat commented Nov 18, 2017

0crat commented Nov 18, 2017

0crat commented Nov 23, 2017

0crat commented Nov 23, 2017

codecov-io commented Aug 4, 2017 •

edited

Loading