Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OO matchers instead of statics #928

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

victornoel
Copy link
Collaborator

This is for #903.

I continued the work on migrating to OO matchers by doing the whole map package.

I also enabled the forbidden apis maven plugin only for this package and bytes (that was done for #588) so that we don't regress with time.

I updated the @todo so that work can continue.

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

Job #928 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jul 7, 2018

Codecov Report

Merging #928 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #928   +/-   ##
========================================
  Coverage      87.2%   87.2%           
  Complexity     1477    1477           
========================================
  Files           260     260           
  Lines          3799    3799           
  Branches        208     208           
========================================
  Hits           3313    3313           
  Misses          439     439           
  Partials         47      47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050dd73...4dfdea1. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Sep 11, 2018

@llorllale/z everybody who has role REV is banned at #928; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 16, 2018

@llorllale/z everybody who has role REV is banned at #928; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@llorllale
Copy link
Contributor

@0crat boost 4x

@llorllale
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 20, 2018

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4dfdea1 into yegor256:master Sep 20, 2018
@rultor
Copy link
Collaborator

rultor commented Sep 20, 2018

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

@0crat boost 4x (here)

@llorllale Boost 4x was set for #928

@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

Job gh:yegor256/cactoos#928 is not assigned, can't get performer

@0crat 0crat removed the scope label Sep 20, 2018
@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

The job #928 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

Boosting tasks is against our principles, see §15: -10 point(s) just awarded to @llorllale/z

@victornoel victornoel deleted the 903-more-oo-tests branch September 21, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants