ProtectedMethodInFinalClassCheck should be stricter

[victornoel]

This is a follow-up on #901.

Basically, now that protected is accepted in final class when a method is an overriding one, it is possible for someone to override a default scoped method by making it protected in a final class.

This should be forbidden.

See #901 (comment) for some design considerations.

[0crat]

@krzyk/z please, pay attention to this issue

[0crat]

@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

[krzyk]

@0crat in

[0crat]

@0crat in (here)

@krzyk Job #917 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV is banned at #917; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0pdd]

@victornoel the puzzle #1006 is still not solved.

[paulodamaso]

@victornoel Merged, please close.

[victornoel]

@paulodamaso thx

[victornoel]

@paulodamaso if I understand correctly, the bug is not fixed yet, we have to wait for #1006 now?

[paulodamaso]

@victornoel Yes, I've break the task in two 30min tasks each: in #993 I've implemented the tests, and the rest will be made in #1006; PDD in action!

[0crat]

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #917 is now out of scope

[ypshenychka]

@0crat quality good

[0crat]

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

[0pdd]

@victornoel the only puzzle #1006 is solved here.