Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#901 allow protected methods if they have override annotation #915

Merged
merged 1 commit into from
Jul 28, 2018

Conversation

krzyk
Copy link
Collaborator

@krzyk krzyk commented Jul 28, 2018

#901

  • protected methods are now allowed if they are inherited (and have @Override annotation)
  • updated test

@0crat 0crat added the scope label Jul 28, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

Job #915 is now in scope, role is REV

@krzyk
Copy link
Collaborator Author

krzyk commented Jul 28, 2018

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 28, 2018

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 98d4052 into yegor256:master Jul 28, 2018
@rultor
Copy link
Collaborator

rultor commented Jul 28, 2018

@rultor merge

@krzyk Done! FYI, the full log is here (took me 20min)

@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

@krzyk/z everybody who has role REV is banned at #915; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

Job gh:teamed/qulice#915 is not assigned, can't get performer

@0crat 0crat removed the scope label Jul 28, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 28, 2018

The job #915 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants