For #72: Introduce error mechanics. #75
Conversation
|
Job #75 is now in scope, role is |
|
This pull request #75 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
| * @author Paulo Lobo ([email protected]) | ||
| * @version $Id$ | ||
| * @since 1.0 | ||
| * @todo #72:30min Implement DyError and DyErrors methods. These |
There was a problem hiding this comment.
@paulodamaso I believe you mean classes here instead of methods.
There was a problem hiding this comment.
@pinaf Actually I was meaning "methods from DyError and DyErrors", but I'll stick to your suggestion since it describes the issue better.
| * Delete it. | ||
| * @throws IOException If fails | ||
| */ | ||
| void delete() throws IOException; |
There was a problem hiding this comment.
@paulodamaso why do we want to delete errors?
There was a problem hiding this comment.
@pinaf After we see the error on error page it would be deleted, just like en Event
| @@ -54,6 +54,9 @@ | |||
| * @author Yegor Bugayenko ([email protected]) | |||
| * @version $Id$ | |||
| * @since 0.13 | |||
| * @todo #72:30min Errors occurred during execution must be saved and later | |||
| * showed to user. Wire Error and Errors implementations in Exec flow so these | |||
| * errors are properly logged once they happen. Cover this with tests. | |||
There was a problem hiding this comment.
@paulodamaso how about a puzzle for listing the errors and displaying them somewhere?
There was a problem hiding this comment.
@pinaf That's exactly what this puzzle is about. Let me reword it to become more clear.
|
@pinaf Made some changes, please take a look now. |
|
@paulodamaso thanks |
|
@carlosmiranda good to merge |
|
@rultor merge |
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here |
@carlosmiranda Done! FYI, the full log is here (took me 14min) |
|
@ypshenychka/z please review this job completed by @pinaf/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #75 is now out of scope |
|
Payment to |
|
@ypshenychka I confirm. |
|
@pinaf thanks |
|
@0crat quality acceptable |
|
@0crat quality acceptable |
|
@ypshenychka There is no quality review for #75, no performer |
|
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
For #72: Introduce error mechanics:
ErrorandErrorsinterfacesUserto return user errorsDyErrorandDyErrorsimplementations