Fixed bug in add() pipe validation #26

amihaiemil · 2016-05-24T11:44:34Z

PR for #22 .
Changes in methods: TkPipeAdd.add(String) and DyPipes.add(String). Other lines in some files ($Id$) were automatically changed by git when I checked them out.

Also, I fixed a mistake in .gitattribtues . Specified eol=lf for .java and .xml files specifically, since it breaks the images if I simply specify *

yegor256 · 2016-06-27T19:05:50Z

@rultor try to merge

rultor · 2016-06-27T19:06:42Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-06-27T19:08:41Z

@rultor try to merge

@amihaiemil @yegor256 Oops, I failed. You can see the full log here (spent 2min)

+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone [email protected]:yegor256/wring.git repo
Cloning into 'repo'...
Warning: Permanently added the RSA host key for IP address '192.30.253.112' to the list of known hosts.
+ cd repo
+ git config user.email [email protected]
+ git config user.name rultor
+ '[' -z 'sudo gem install pdd' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo gem install pdd' ';' 'java -version' ';' 'mvn help:system clean install -Pqulice --settings ../settings.xml' ';' 'mvn clean site -Psite --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ rm -rf .gpg
+ cd repo
+ git remote add fork [email protected]:amihaiemil/wring.git
+ git remote update
Fetching origin
Fetching fork
From github.com:amihaiemil/wring
 * [new branch]      22         -> fork/22
 * [new branch]      master     -> fork/master
+ args=
+ '[' default == default ']'
+ args=' --ff'
+ '[' default == no ']'
+ '[' default == only ']'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ git show-branch __rultor
++ wc -l
+ '[' 0 -gt 0 ']'
+ git checkout -B __rultor fork/22
error: Your local changes to the following files would be overwritten by checkout:
    src/main/java/io/wring/agents/Agent.java
    src/main/java/io/wring/agents/Cycle.java
    src/main/java/io/wring/agents/Exec.java
    src/main/java/io/wring/agents/FkAgent.java
    src/main/java/io/wring/agents/IgnoreEvents.java
    src/main/java/io/wring/agents/JsonAgent.java
    src/main/java/io/wring/agents/Printable.java
    src/main/java/io/wring/agents/Refill.java
    src/main/java/io/wring/agents/Routine.java
    src/main/java/io/wring/agents/ThreadAppender.java
    src/main/java/io/wring/agents/github/AgGithub.java
    src/main/java/io/wring/agents/github/BoCommit.java
    src/main/java/io/wring/agents/github/BoIssue.java
    src/main/java/io/wring/agents/github/Body.java
    src/main/java/io/wring/agents/github/Subject.java
    src/main/java/io/wring/dynamo/DyBase.java
    src/main/java/io/wring/dynamo/DyVault.java
Please, commit your changes or stash them before you can switch branches.
Aborting
'cid' file is absent, container wasn't started correctly

amihaiemil · 2016-06-27T19:18:53Z

@yegor256 git acts funny about that $Id$ . I have the same behaviour when I checkout the repo and try to switch to branch 22. Did you ever encounter this before?

yegor256 · 2016-06-27T19:22:37Z

@amihaiemil I think you should not touch that $Id$ placeholders in source files. they are replaced by Git automatically

This reverts commit 1418973.

amihaiemil · 2016-06-27T20:02:58Z

@yegor256 I reverted the changes to the $Id$ . Something seems off anyway - git automatically removes the id when I checkout the files and they all appear modified in my local repo.

Plus, if you look in the history apparently the files had the same id when I first checked them out
c79829f9e91907f21c716854779af4233e496fa9

yegor256 · 2016-06-27T20:27:09Z

@rultor merge

rultor · 2016-06-27T20:27:39Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-06-27T20:28:05Z

@rultor merge

@amihaiemil @yegor256 Oops, I failed. You can see the full log here (spent 19s)

+ chmod 600 /home/rultor/.ssh/config
+ git clone [email protected]:yegor256/wring.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email [email protected]
+ git config user.name rultor
+ '[' -z 'sudo gem install pdd' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo gem install pdd' ';' 'java -version' ';' 'mvn help:system clean install -Pqulice --settings ../settings.xml' ';' 'mvn clean site -Psite --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ rm -rf .gpg
+ cd repo
+ git remote add fork [email protected]:amihaiemil/wring.git
+ git remote update
Fetching origin
Fetching fork
From github.com:amihaiemil/wring
 * [new branch]      22         -> fork/22
 * [new branch]      master     -> fork/master
+ args=
+ '[' default == default ']'
+ args=' --ff'
+ '[' default == no ']'
+ '[' default == only ']'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ wc -l
++ git show-branch __rultor
+ '[' 0 -gt 0 ']'
+ git checkout -B __rultor fork/22
Switched to a new branch '__rultor'
M   src/main/java/io/wring/agents/Agent.java
M   src/main/java/io/wring/agents/Exec.java
M   src/main/java/io/wring/agents/FkAgent.java
M   src/main/java/io/wring/agents/IgnoreEvents.java
M   src/main/java/io/wring/agents/JsonAgent.java
M   src/main/java/io/wring/agents/Printable.java
M   src/main/java/io/wring/agents/Refill.java
M   src/main/java/io/wring/agents/Routine.java
M   src/main/java/io/wring/agents/ThreadAppender.java
M   src/main/java/io/wring/agents/github/AgGithub.java
M   src/main/java/io/wring/agents/github/BoCommit.java
M   src/main/java/io/wring/agents/github/BoIssue.java
M   src/main/java/io/wring/agents/github/Body.java
M   src/main/java/io/wring/agents/github/Subject.java
M   src/main/java/io/wring/dynamo/DyBase.java
M   src/main/java/io/wring/dynamo/DyVault.java
Branch __rultor set up to track remote branch 22 from fork.
+ git checkout -B master origin/master
error: Your local changes to the following files would be overwritten by checkout:
    src/main/java/io/wring/agents/BoostEvents.java
    src/main/java/io/wring/agents/Cycle.java
Please, commit your changes or stash them before you can switch branches.
Aborting
'cid' file is absent, container wasn't started correctly

yegor256 · 2016-06-27T20:31:44Z

@amihaiemil I think you need to merge master into your branch

amihaiemil · 2016-06-27T21:21:34Z

@yegor256 try now, maybe? I had to do the merge manually since git wouldn't let me. It changes the ID instantly, I can't even do git checkout -- . : the operation works fine, but then I do git status and changes are there again :))

yegor256 · 2016-06-27T22:52:20Z

@rultor try to merge

rultor · 2016-06-27T22:52:44Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-06-27T22:54:15Z

@rultor try to merge

@amihaiemil @yegor256 Oops, I failed. You can see the full log here (spent 1min)

+ chmod 600 /home/rultor/.ssh/config
+ git clone [email protected]:yegor256/wring.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email [email protected]
+ git config user.name rultor
+ '[' -z 'sudo gem install pdd' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'sudo gem install pdd' ';' 'java -version' ';' 'mvn help:system clean install -Pqulice --settings ../settings.xml' ';' 'mvn clean site -Psite --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ rm -rf .gpg
+ cd repo
+ git remote add fork [email protected]:amihaiemil/wring.git
+ git remote update
Fetching origin
Fetching fork
From github.com:amihaiemil/wring
 * [new branch]      22         -> fork/22
 * [new branch]      master     -> fork/master
+ args=
+ '[' default == default ']'
+ args=' --ff'
+ '[' default == no ']'
+ '[' default == only ']'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ wc -l
++ git show-branch __rultor
+ '[' 0 -gt 0 ']'
+ git checkout -B __rultor fork/22
Switched to a new branch '__rultor'
M   src/main/java/io/wring/agents/Agent.java
M   src/main/java/io/wring/agents/Exec.java
M   src/main/java/io/wring/agents/FkAgent.java
M   src/main/java/io/wring/agents/IgnoreEvents.java
M   src/main/java/io/wring/agents/JsonAgent.java
M   src/main/java/io/wring/agents/Printable.java
M   src/main/java/io/wring/agents/Refill.java
M   src/main/java/io/wring/agents/Routine.java
M   src/main/java/io/wring/agents/ThreadAppender.java
M   src/main/java/io/wring/agents/github/AgGithub.java
M   src/main/java/io/wring/agents/github/BoCommit.java
M   src/main/java/io/wring/agents/github/BoIssue.java
M   src/main/java/io/wring/agents/github/Body.java
M   src/main/java/io/wring/agents/github/Subject.java
M   src/main/java/io/wring/dynamo/DyBase.java
M   src/main/java/io/wring/dynamo/DyVault.java
Branch __rultor set up to track remote branch 22 from fork.
+ git checkout -B master origin/master
error: Your local changes to the following files would be overwritten by checkout:
    src/main/java/io/wring/agents/BoostEvents.java
    src/main/java/io/wring/agents/Cycle.java
Please, commit your changes or stash them before you can switch branches.
Aborting
'cid' file is absent, container wasn't started correctly

yegor256 · 2017-10-06T08:22:28Z

@amihaiemil what's up with this PR?

amihaiemil · 2017-10-06T09:32:27Z

@yegor256 it's so old I don't even remember. It's probably not even applicable anymore. Closing it :)

yegor256 · 2017-10-06T11:46:42Z

@amihaiemil it's still applicable, the bug is still there. It's a pity you closed it, the code was correct, there were just merge problems.

0crat · 2017-10-06T12:45:49Z

@yegor256 please, pay attention to this pull request

0crat · 2017-10-06T12:46:03Z

Job gh:yegor256/wring#26 is in scope.

yegor256 · 2018-03-16T16:16:01Z

@amihaiemil I'm sorry it took two years to review your PR :) Please, fix the code above and let's merge it, it's a good PR.

amihaiemil · 2018-03-16T16:40:55Z

@yegor256 I have no idea what's happening, some settings may be not ok in this repo. I cloned my fork locally and it had about 10 files changed automatically, that git $Id$ deleted... I remember I had this issue here also 2 years ago

yegor256 · 2018-03-22T10:09:31Z

@amihaiemil the bug is still there, I believe. If you post an empty pipe, the system crashes with an exception.

amihaiemil · 2018-03-22T10:15:36Z

@yegor256 I'll try to make another clean PR. Reclone the repo and everything. But I still don't undertand why the weird behaviour with the $Id -- when I clone it locall git automatically deletes the generated IDs and shows all files as modified. Sure there isn't some misplaced setting somewhere? Never had it in any other repo.

0crat · 2018-04-12T05:36:11Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

0crat · 2018-04-17T08:36:50Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

0crat · 2018-04-22T14:36:51Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

0crat · 2018-04-27T16:36:37Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat · 2018-05-03T01:36:47Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 · 2018-05-06T05:09:22Z

@0crat assign me

0crat · 2018-05-06T05:10:39Z

@0crat assign me (here)

@yegor256 The job #26 assigned to @yegor256 /z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

0crat · 2018-05-06T05:11:09Z

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256 /z

0crat · 2018-05-08T03:35:42Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat · 2018-05-13T04:37:34Z

@yegor256 /z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 · 2018-05-14T13:34:30Z

@0crat out

0crat · 2018-05-14T13:37:25Z

@0crat out (here)

@yegor256 GitHub issue is still open, won't close

yegor256 · 2018-05-14T13:41:46Z

@0crat status

0crat · 2018-05-14T13:43:53Z

@0crat status (here)

@yegor256 This is what I know about this job, as in §32:

The job #26 is in scope for 8days
The role is DEV
The job is assigned to @yegor256 /z for 8days
There is no monetary reward attached, it's a free job
The job doesn't have any impediments
The budget is 30 minutes/points
These users are banned and won't be assigned:
- @amihaiemil /z: This user reported the ticket
Job footprint (restricted area)

0crat · 2018-05-18T05:37:39Z

@yegor256 /z everybody who has role DEV are banned at #26; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat · 2018-05-23T07:35:47Z