For #76: Exec register error tests. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job #79 is now in scope, role is |
|
This pull request #79 is assigned to @pinaf/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @carlosmiranda/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
|
@pinaf ping |
pinaf
reviewed
Oct 30, 2018
|
|
||
| @Override | ||
| public Iterable<Directive> asXembly() throws IOException { | ||
| throw new UnsupportedOperationException("not implemented"); |
There was a problem hiding this comment.
@paulodamaso let's add a puzzle for the implementation of this method
|
|
||
| @Override | ||
| public void delete() throws IOException { | ||
| throw new UnsupportedOperationException("delete() not implemented"); |
There was a problem hiding this comment.
@paulodamaso let's add a puzzle for the implementation of this method
|
@pinaf Please take a look. |
|
@paulodamaso thanks |
|
@carlosmiranda ping |
|
@rultor merge |
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here |
@carlosmiranda @paulodamaso Oops, I failed. You can see the full log here (spent 8min) |
pinaf
reviewed
Oct 31, 2018
| } | ||
|
|
||
| @Override | ||
| public Iterable<Error> iterate() throws IOException { |
There was a problem hiding this comment.
@paulodamaso let's remove the exception here
|
@pinaf I think that it's good now |
|
@paulodamaso yep, thanks! |
|
@rultor merge |
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here |
@carlosmiranda Done! FYI, the full log is here (took me 14min) |
|
@ypshenychka/z please review this job completed by @pinaf/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #79 is now out of scope |
|
There is an unrecoverable failure on my side. Please, submit it here: 0.37.5: CID: 947424ae-7e84-4d69-8404-d4fc2a40fbad, Type: "Send zold" |
|
Payment to |
|
@0crat quality good |
|
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #76:
Execerror register;ErrorandErrorsExecto receive error repository reference