Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license config in pom.xml #49

Closed
mentiflectax opened this issue Jan 21, 2015 · 12 comments
Closed

Missing license config in pom.xml #49

mentiflectax opened this issue Jan 21, 2015 · 12 comments

Comments

@mentiflectax
Copy link
Contributor

Please put <license>file:${basedir}/LICENSE.txt</license> into the pom.xml of xembly, otherwise we'll be getting checkstyle errors (no header) upon fresh checkout.

@yegor256 yegor256 added the bug label Jan 21, 2015
@maurezen
Copy link
Contributor

This is a known bug of qulice configuration in parent-0.31 (jcabi/jcabi-parent#19). I suggest upgrading the parent version to 0.32.1, which contains the fix.

@davvd
Copy link

davvd commented Jan 22, 2015

we'll find someone to do this task, soon

@davvd
Copy link

davvd commented Jan 22, 2015

@dpisarenko thanks for the ticket, your account was topped for 15 mins, payment 50593083

@davvd
Copy link

davvd commented Jan 28, 2015

@maurezen the task is yours please proceed

@maurezen
Copy link
Contributor

@dpisarenko how comes that there is already a license added? I see a sneak commit in #50.
Anyway, updated the parent and removed the license from xembly config in

@davvd pull request #51

@mentiflectax
Copy link
Contributor Author

@maurezen Probably I added it to run mvn qulice:check -Pqulice locally.

@mentiflectax
Copy link
Contributor Author

@maurezen No, I don't think you should submit PR #51 because then the exact error I had will occur. At https://github.com/yegor256/xembly/pull/51/files I see that you removed <license>file:${basedir}/LICENSE.txt</license> from the POM and this was exactly the problem.

@maurezen
Copy link
Contributor

@dpisarenko I also changed the parent version, which now has this exact configuration snippet on the parent level in a correct place, so xembly will inherit it. Therefore, no more need to declare explicitly on a child level.

@mentiflectax
Copy link
Contributor Author

@maurezen Alright then. I'll close the issue when PR #51 is merged.

@maurezen
Copy link
Contributor

@dpisarenko pull request #51 merged, please close.

@maurezen
Copy link
Contributor

maurezen commented Feb 5, 2015

@davvd the task is already closed.

@davvd
Copy link

davvd commented Feb 6, 2015

@maurezen Thanks for your contribution, 30 mins was added to your account, payment ID is 51287972

+30 added to your rating, current score is: +960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants