Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qulice configuration is ignored in children #19

Closed
maurezen opened this issue Jan 14, 2015 · 6 comments
Closed

Qulice configuration is ignored in children #19

maurezen opened this issue Jan 14, 2015 · 6 comments

Comments

@maurezen
Copy link
Contributor

In children projects parent's qulice configuration is ignored. This leads to the bugs like jcabi/jcabi-email#11 and jcabi/jcabi-manifests#16.

mvn help:effective-pom does list qulice configuration present.
mvn help:active-profiles does list qulice profile present.

mvn -X qulice:check -Pqulice lists the following:

[DEBUG] Goal: com.qulice:qulice-maven-plugin:0.10:check (default-cli)
[DEBUG] Style: Regular
[DEBUG] Configuration:
< configuration>
< asserts>${qulice.asserts}< /asserts>
< excludes>${qulice.excludes}< /excludes>
< license default-value="LICENSE.txt">${qulice.license}< /license>
< skip default-value="false">${qulice.skip}< /skip>
< project default-value="${project}"/>
< session default-value="${session}"/>
< /configuration>

and

[DEBUG] Configuring mojo 'com.qulice:qulice-maven-plugin:0.10:check' with basic configurator -->
[DEBUG] '(s) asserts = []
[DEBUG] '(s) excludes = []
[DEBUG] '(s) license = LICENSE.txt
[DEBUG] '(s) skip = false
[DEBUG] '(s) project = MavenProject: com.jcabi:jcabi-manifests:2.0-SNAPSHOT @ %path to project%\jcabi-manifests\pom.xml
[DEBUG] '(f) session = org.apache.maven.execution.MavenSession@6889634c
[DEBUG] -- end configuration --

@yegor256
Copy link
Member

@maurezen that's true, we should move these three lines to the <plugin> section, thanks for reporting

@yegor256 yegor256 added the bug label Jan 14, 2015
maurezen added a commit to maurezen/jcabi-manifests that referenced this issue Jan 14, 2015
Would be great to remove the inlined configuration after jcabi/jcabi-parent#19 is fixed.
@dmarkov
Copy link

dmarkov commented Jan 15, 2015

we'll find someone to do this task, soon

@dmarkov
Copy link

dmarkov commented Jan 16, 2015

@Marczeeee can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here... Budget here is 30 mins (keep this principle in mind)

@dmarkov
Copy link

dmarkov commented Jan 16, 2015

@maurezen thank you for the ticket reported, I topped your account for 15 mins, transaction 50302740

@Marczeeee
Copy link
Contributor

@maurezen Pull request #20 was merged. Please close this issue.

@dmarkov
Copy link

dmarkov commented Jan 22, 2015

@Marczeeee I added 30 mins to your account, many thanks for working with the project!; added +30 to your rating, now it is equal to +90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants