Skip to content

Commit

Permalink
Fix a unit test of sks, remove activator populated condition when no …
Browse files Browse the repository at this point in the history
…activator endpoints and forcing into serve mode (knative#15278)
  • Loading branch information
yenniechen committed May 31, 2024
1 parent ba729e4 commit 37fe895
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/reconciler/serverlessservice/serverlessservice_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func TestReconcile(t *testing.T) {
Name: "force serve mode, no endpoints",
Key: "force/serve",
Objects: []runtime.Object{
SKS("force", "serve", withProxyMode, markHappy, WithPubService, WithPrivateService, WithDeployRef("bar")),
SKS("force", "serve", WithProxyMode, markHappy, WithPubService, WithPrivateService, WithDeployRef("bar")),
deploy("force", "bar"),
svcpub("force", "serve"),
svcpriv("force", "serve"),
Expand Down Expand Up @@ -772,6 +772,10 @@ func markNoEndpoints(sks *nv1a1.ServerlessService) {
sks.Status.MarkActivatorEndpointsPopulated()
}

func markNoActivatorEndpoints(sks *nv1a1.ServerlessService) {
sks.Status.MarkActivatorEndpointsRemoved()
}

func withHTTP2Protocol(sks *nv1a1.ServerlessService) {
sks.Spec.ProtocolType = pkgnet.ProtocolH2C
}
Expand Down

0 comments on commit 37fe895

Please sign in to comment.