Adding typescript support to generator-angular #539

eggers · 2014-01-07T03:37:06Z

There have been a few other projects that have tried to support typescript with the angular generator (e.g. anchann and JakubMrozek), but are currently out of date. It would be great if we could get this merged in so that we can try keeping it current.

eddiemonge · 2014-01-07T03:41:53Z

How is this different from #313?

eggers · 2014-01-07T16:47:50Z

@eddiemonge This is essentially a replacement for #313 which is now out of date as it was made 5 months ago. I also tried to keep the change smaller (22 changed files with 396 additions and 10 deletions vs 30 changed files with 604 additions and 83 deletions for #313), and typescriptify the ts files a bit more.

jednano · 2014-01-08T23:36:06Z

route/index.js

  var config = {
    file: path.join(
      this.env.options.appPath,
-      'scripts/app.' + (coffee ? 'coffee' : 'js')
+      'scripts/app.' + (coffee ? 'coffee' : typescript ? 'ts': 'js')


Are you sure the splicable section doesn't also need a condition for typescript? Maybe (coffee || typescript)?

Yeah, because typescript is a superset of javascript, so it has the same syntax as javascript. CoffeeScript has different language syntax.

Great. Just making sure.

jednano · 2014-01-09T00:07:49Z

Aren't you also supposed to copy over the templates/javascript-min folder to templates/typescript-min?

jednano · 2014-01-09T00:09:21Z

Is 'use strict'; required at the top of TypeScript files too?

jednano · 2014-01-09T00:14:31Z

templates/typescript/app.ts

@@ -0,0 +1,19 @@
+/// <reference path="../bower_components/definitivelyTyped/angularjs/angular.d.ts" />
+<% if (ngRoute) { %>/// <reference path="../bower_components/definitivelyTyped/angularjs/angular-route.d.ts" /><% } %>
+/// <reference path="../bower_components/definitivelyTyped/angularjs/angular-resource.d.ts" />


These module references should be conditional.

It was a bunch of extra steps to get the other references to be conditional, though it would probably be a good idea.

eggers · 2014-01-09T01:07:16Z

@jedmao Thanks for all of your code review. I'm making your suggested changes as I type except where I commented. As for the other comments:

typescript doesn't automatically add use strict; to the compiled javascript unless you specific it explicitly.
I didn't copy javascript-min over because it's deprecated anyhow since ng-min does the work already.

jednano · 2014-01-09T03:00:46Z

templates/common/_bower.json

-    "angular-scenario": "1.2.6"
+    "angular-scenario": "1.2.6"<% if (typescript) { %>,
+    "dt-jasmine": "~2.0.0",
+    "dt-angular": "https://github.com/jedmao/dt-angular/archive/v1.2.0.tar.gz"<% } %>


Can we switch the placement of these two so they are listed alphabetically? I find it's sometimes hard to find what I'm looking for in these manifest files when they aren't alphabetical.

TypeScript Fixes

jednano · 2014-01-12T21:48:09Z

I think this is ready for some code review. Let @eggers know if we need a squash.

bsr203 · 2014-03-04T00:48:05Z

can u please commnet how to install that branch. I tried something like,

npm install -g git://github.com/eggers/generator-angular/tree/ngdocs

which didn't work. thanks again.

I saw options like, build only changed filed, etc :-)

On Mon, Mar 3, 2014 at 7:28 PM, eggers [email protected] wrote:

Just redo yo angular - - typescript. It will overwrite the grunt.js, you
may also need to delete your .js files.

Also, I prefer my #ngdocs branch. It has some additional niceties.

Reply to this email directly or view it on GitHubhttps://github.com//pull/539#issuecomment-36578756
.

bsr203 · 2014-03-04T00:52:05Z

looks like this worked.. npm install -g git://github.com/eggers/generator-angular#ngdocs

bsr203 · 2014-03-04T02:25:44Z

@eggers can you please check the incremental compilation works. I just cloned the project, and modified two files (just whitespace). I see it compiles previous changes too.

I tried to debug this, as it works for me with jade compilation. Only difference I could see is

jade: {
                options: {
                    nospawn: true,
                    livereload: true
                },

vs

typescript: {
                options: {
                    spawn: false
                },

but, changing that too didn't work

Running "connect:livereload" (connect) task
Started connect web server on 127.0.0.1:9000.

Running "watch" task
Waiting...OK
>> File "app/scripts/app.ts" changed.


Running "typescript:base" (typescript) task
3 files created. js: 1 file, map: 1 file, declaration: 1 file

Running "ngdocs:api" (ngdocs) task
Generating Documentation...
DONE. Generated 2 pages in 67ms.

Running "watch" task
... Reload app/scripts/app.ts ...
... Reload app/scripts/app.ts ...
Completed in 13.196s at Mon Mar 03 2014 21:20:09 GMT-0500 (EST) - Waiting...
OK
>> File "app/scripts/controllers/main.ts" changed.


Running "typescript:base" (typescript) task
6 files created. js: 2 files, map: 2 files, declaration: 2 files

Running "ngdocs:api" (ngdocs) task
Generating Documentation...
DONE. Generated 2 pages in 56ms.

Running "watch" task
... Reload app/scripts/app.ts ...
... Reload app/scripts/controllers/main.ts ...
... Reload app/scripts/app.ts ...
... Reload app/scripts/controllers/main.ts ...
Completed in 13.558s at Mon Mar 03 2014 21:20:38 GMT-0500 (EST) - Waiting...

eddiemonge · 2014-03-27T23:56:50Z

Haven't forget about this but need to do some more testing and other things first

kclay · 2014-05-15T14:53:53Z

Whats the current status on this, looking to start a new project leveraging play+typescript+angular

piotrwitek · 2014-06-13T14:22:47Z

please give an update on TypeScript integration progress. Thx.

stevemao · 2014-07-06T00:57:53Z

Still reviewing this PR?

eddiemonge · 2014-07-06T18:25:57Z

its on hold at the moment while the generator is being updated

vpassapera · 2014-08-31T20:42:58Z

Is it going to be merged any time soon?

@eggers doesn't seem like you have rebased in a while, is this still alive?

thanks!

eddiemonge · 2014-09-03T17:34:46Z

its on hold from me, not the author of this pr.

eggers · 2014-09-03T20:41:13Z

I will rework once the generator has been updated based upon my findings
and the new structure.

refactor(app:templates:server): deprecate sendfile -- use sendFile instead

gilamran · 2014-12-21T09:37:14Z

Any news regarding this pull request?

michikono · 2014-12-28T03:05:33Z

+1

eddiemonge · 2014-12-30T19:12:28Z

not yet

moneytree-doug · 2015-01-21T06:02:37Z

👍 Any updates?

luisrudge · 2015-01-21T09:16:45Z

I think its best to create a generator-angular-typescript and be done with it. No one from this project really care, unfortunately.

mohlman3 · 2015-02-01T19:49:37Z

+1

keichi · 2015-05-13T02:43:06Z

+1 for this.

reroslyn · 2015-05-20T10:13:36Z

+1 for this!

awk · 2015-05-26T21:35:13Z

This pull request seems to have gone stale in the past 6-8 months. I just created #1098 which is based on this one but with updates for the latest version of generator-angular and also to use tsd/definitelyTyped to pull the .d.ts files

danielsiwiec · 2015-07-10T22:41:21Z

+1

rogerpadilla · 2015-10-20T00:39:27Z

+1

eddiemonge · 2015-10-20T18:33:11Z

why are you +1 this? its already been added

Jacob Eggers added 5 commits January 7, 2014 03:05

Copying javascript files to typescript directory.

c494011

Adding typescript options

f0806c0

Adding typescript references.

8c062da

Adding typescript references.

acf9cff

TypeScriptifying the generators.

c7a37fa

Jacob Eggers added 2 commits January 7, 2014 17:20

Adding karma task to typescript:test

3ba295b

Updating readme for typescript.

3041dd5

jednano reviewed Jan 8, 2014
View reviewed changes

jednano reviewed Jan 9, 2014
View reviewed changes

Fixes based on comments by @jedmao

96ab8cb

jednano reviewed Jan 9, 2014
View reviewed changes

Jed Mao and others added 6 commits January 9, 2014 10:11

Add conditional references

9008eb8

Fix indentation, use lambdas

deaf7bd

Remove angular reference from specs

c79c9b6

Add type information where it wasn't before

1475034

Fix $delegate type

9c9a7dc

Merge pull request #1 from jedmao/eggers-ts

a6535ff

TypeScript Fixes

eddiemonge added this to the 0.10.0: The Future milestone Jun 5, 2014

eddiemonge added the on-hold label Jun 5, 2014

kevva force-pushed the master branch from 03fd637 to e352ac4 Compare September 1, 2014 11:47

stevemao pushed a commit to stevemao/generator-angular that referenced this pull request Nov 6, 2014

Merge pull request yeoman#539 from cesarvargas00/master

21d52c9

refactor(app:templates:server): deprecate sendfile -- use sendFile instead

bzz mentioned this pull request Feb 6, 2015

Using TypeScript in Zeppelin frontend webapp ZEPL/zeppelin#321

Closed

3 tasks

awk mentioned this pull request May 26, 2015

Adding typescript support to generator-angular #1098

Closed

eddiemonge closed this Jul 10, 2015

Adding typescript support to generator-angular #539

Adding typescript support to generator-angular #539

Conversation

eggers commented Jan 7, 2014

eddiemonge commented Jan 7, 2014

eggers commented Jan 7, 2014

jednano Jan 8, 2014

Choose a reason for hiding this comment

eggers Jan 9, 2014

Choose a reason for hiding this comment

jednano Jan 9, 2014

Choose a reason for hiding this comment

jednano commented Jan 9, 2014

jednano commented Jan 9, 2014

jednano Jan 9, 2014

Choose a reason for hiding this comment

eggers Jan 9, 2014

Choose a reason for hiding this comment

eggers commented Jan 9, 2014

jednano Jan 9, 2014

Choose a reason for hiding this comment

jednano commented Jan 12, 2014

bsr203 commented Mar 4, 2014

bsr203 commented Mar 4, 2014

bsr203 commented Mar 4, 2014

eddiemonge commented Mar 27, 2014

kclay commented May 15, 2014

piotrwitek commented Jun 13, 2014

stevemao commented Jul 6, 2014

eddiemonge commented Jul 6, 2014

vpassapera commented Aug 31, 2014

eddiemonge commented Sep 3, 2014

eggers commented Sep 3, 2014

gilamran commented Dec 21, 2014

michikono commented Dec 28, 2014

eddiemonge commented Dec 30, 2014

moneytree-doug commented Jan 21, 2015

luisrudge commented Jan 21, 2015

mohlman3 commented Feb 1, 2015

keichi commented May 13, 2015

reroslyn commented May 20, 2015

awk commented May 26, 2015

danielsiwiec commented Jul 10, 2015

rogerpadilla commented Oct 20, 2015

eddiemonge commented Oct 20, 2015