-
Notifications
You must be signed in to change notification settings - Fork 339
Conversation
Why do we need run.js in root? Can't you move it in test/? |
Sorry. I forgot remove it. It will be done. |
It's done. Will it be merged? |
I'll leave this to @stephanebachelier. But you should squash those 2 commits. |
Squash again? 😓 Let's go... |
It's done. |
Any feedback guys? I'm using my own repository but I wish move to the right target 😊 |
Any reason you use parse5 instead of cheerio? |
Only one reason, performance! |
@marcelaraujo sorry for the delay, client work in the pipe. I really want to merge your work as it's a major feature and will solve lots of issues in this repo. I come back to you this week after having made some tests on real projects. |
@marcelaraujo @XhmikosR I would like to have the #518 to pass before if it might be accepted, as I had hard time rebasing the work done in #306. This PR should be easy to rebase on #518. |
Ok. 👍 |
@marcelaraujo BTW feel free to ping me if I ever get lost in client work :) |
I don't think we will have problems between both PR's because we work on different files. Maybe some tests will break... maybe... :) |
@marcelaraujo I've created a |
:)
@stephanebachelier It's squashed into one single commit.
Thanks