Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Added HTML parser support #528

Closed
wants to merge 1 commit into from
Closed

Conversation

marcelaraujo
Copy link

:)

@stephanebachelier It's squashed into one single commit.

Thanks

@XhmikosR
Copy link
Contributor

Why do we need run.js in root? Can't you move it in test/?

@marcelaraujo
Copy link
Author

Sorry. I forgot remove it. It will be done.

@marcelaraujo
Copy link
Author

It's done.

Will it be merged?

@XhmikosR
Copy link
Contributor

I'll leave this to @stephanebachelier. But you should squash those 2 commits.

@marcelaraujo
Copy link
Author

Squash again?

😓

Let's go...

@marcelaraujo
Copy link
Author

It's done.

@marcelaraujo
Copy link
Author

Any feedback guys?

I'm using my own repository but I wish move to the right target

😊

@stevemao
Copy link
Contributor

Any reason you use parse5 instead of cheerio?

@marcelaraujo
Copy link
Author

Only one reason, performance!

@stephanebachelier
Copy link
Collaborator

@marcelaraujo sorry for the delay, client work in the pipe. I really want to merge your work as it's a major feature and will solve lots of issues in this repo. I come back to you this week after having made some tests on real projects.

@stephanebachelier
Copy link
Collaborator

@marcelaraujo @XhmikosR I would like to have the #518 to pass before if it might be accepted, as I had hard time rebasing the work done in #306. This PR should be easy to rebase on #518.

@marcelaraujo
Copy link
Author

Ok.

👍

@stephanebachelier
Copy link
Collaborator

@marcelaraujo BTW feel free to ping me if I ever get lost in client work :)

@marcelaraujo
Copy link
Author

I don't think we will have problems between both PR's because we work on different files. Maybe some tests will break... maybe...

:)

@stephanebachelier
Copy link
Collaborator

@marcelaraujo I've created a dev branch to merge majors PR. Could you create another PR on top of dev branch. You can't edit a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants