Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Fix for inconsistent line feed #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for inconsistent line feed #604

wants to merge 1 commit into from

Conversation

lu4
Copy link

@lu4 lu4 commented Oct 31, 2015

Replacing the lines with original method not works for cases when the carrige return is inconsistent across the file, it makes the whole block not to get replaced because after concatenation you get a block which is different from original

@addyosmani
Copy link
Member

Replacing the lines with original method not works for cases when the carrige return is inconsistent across the file,

Do you have a test case or example of this that fails without the patch you've supplied?

@ThomasHambach
Copy link

I can confirm this patch resolves a bug causing the blocks not to be replaced on Windows. Great work @lu4

@eddiemonge
Copy link
Member

Like Addy said, this needs a failing unit test so it can be verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants