Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

include support for baseURL configuration #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include support for baseURL configuration #613

wants to merge 1 commit into from

Conversation

bradford281
Copy link

No description provided.

@fodma1
Copy link

fodma1 commented Mar 8, 2016

This is an awaited feature, I can tell 😄 - I spent more than a day figuring out, how to do it!

@@ -196,10 +197,12 @@ RevvedFinder.prototype.find = function find(ofile, searchDirs) {
// filename = [dirname, filename].join('/');
// }

if (absolute) {
if (absolute && this.baseURL) {
filepath = prefix.substring(1) + filepath; // ignore the first slash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not ignore the first slash unless the baseUrl ends with a slash

@eddiemonge
Copy link
Member

other than the comments seems ok

@duereg
Copy link

duereg commented Nov 10, 2016

@bradford281 what's the status of this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants