This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
fix bug: matching scripts in htmlmined html file #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original regex for matching <script src="..." in html file can only match script tags in different lines. If the content of a html file (for example a html file which has been htmlmined) looks like this: <script src="js/vendor-437841c1.js"></script><script src="js/script-9d21274e.js"></script> It can not be matched correctly. New regex could solve this problem.
|
so it needs a non-greedy lookup? I suppose this is one way of doing it. Once actual html parsing is in then this shouldn't be needed. |
| @@ -7,7 +7,7 @@ var chalk = require('chalk'); | |||
| var _defaultPatterns = { | |||
| html: [ | |||
| [ | |||
| /<script.+src=['"]([^"']+)["']/gm, | |||
| /<script[^\>]+src=['"]([^"']+)["']/gm, | |||
There was a problem hiding this comment.
Could possibly also be:
<script[^>]+?src=['"]([^"']+)["']
|
@eddiemonge |
|
Once we can parse the html then most of the regexes won't be required since we will be able to do something like document.script.src |
|
@eddiemonge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original regex for matching
<script src="..."inhtmlfile can only matchscripttags in different lines.If the content of a
htmlfile (for example ahtmlfile which has beenhtmlmined) looks like this:It can not be matched correctly.
New regex could solve this problem.