skip checks in lstat callback

yepitschunked · Feb 4, 2020 · 758c76a · 758c76a
1 parent f077a64
commit 758c76a
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/packages/jest-haste-map/src/crawlers/node.ts b/packages/jest-haste-map/src/crawlers/node.ts
@@ -61,17 +61,26 @@ function find(
           }
         }
 
+        // If we made it here and had dirent support, we know that
+        // this is a normal file and can skip some checks in the lstat callback below
+        let passedFiletypeChecks = typeof entry !== 'string';
+
         activeCalls++;
 
         fs.lstat(file, (err, stat) => {
           activeCalls--;
 
-          // This logic is unnecessary for node > v10.10, but leaving it in
-          // since we need it for backwards-compatibility still.
-          if (!err && stat && !stat.isSymbolicLink()) {
-            if (stat.isDirectory()) {
-              search(file);
-            } else {
+          if (!err && stat) {
+            if (!passedFiletypeChecks) {
+              if (stat.isSymbolicLink()) {
+                // do nothing
+              } else if (stat.isDirectory()) {
+                search(file);
+              } else {
+                passedFiletypeChecks = true;
+              }
+            }
+            if (passedFiletypeChecks) {
               const ext = path.extname(file).substr(1);
               if (extensions.indexOf(ext) !== -1) {
                 result.push([file, stat.mtime.getTime(), stat.size]);