Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yalp Store forces the user to relogin often #311

Closed
yeriomin opened this issue Nov 3, 2017 · 8 comments
Closed

Yalp Store forces the user to relogin often #311

yeriomin opened this issue Nov 3, 2017 · 8 comments
Milestone

Comments

@yeriomin
Copy link
Owner

yeriomin commented Nov 3, 2017

There has been a change in Google API. The auth token which is used to sign all the requests to the Google API now has a limited validity time.

yeriomin added a commit that referenced this issue Nov 3, 2017
@yeriomin yeriomin added this to the 0.29 milestone Nov 3, 2017
@yeriomin
Copy link
Owner Author

yeriomin commented Nov 3, 2017

The issue should be mostly resolved if you use the built-in account. User's account should work when version 0.29 is out (in a couple of days).

Keep in mind, that testing this requires time (quite obviously). I don't know a way to determine when the token expires, except waiting. Any observations are welcome.

@Miaourt
Copy link

Miaourt commented Nov 4, 2017

Actually, each time I open the app I'm asked to re-log into my account / yalp's one.

Only happen when using root/system permissions for installation

@msdos
Copy link

msdos commented Nov 6, 2017

Actually, each time I open the app I'm asked to re-log into my account / yalp's one.

This is happening to me as well. I just opened #315, is related to this issue?

@walrus543
Copy link

walrus543 commented Nov 8, 2017

After updating to 0.29 I disconnected and connected again. Now everything is working flawlessly including updating several apps in one go.
No need to relogin on my end. Thanks.

@Miaourt
Copy link

Miaourt commented Nov 8, 2017

Same, working flawlessly. Gj @yeriomin !

@MartinX3
Copy link

MartinX3 commented Nov 8, 2017

Thank you, it works now! :D

@msdos
Copy link

msdos commented Nov 8, 2017

0.29 works here as well, I'm using a custom account. Thanks!

@yeriomin
Copy link
Owner Author

yeriomin commented Nov 9, 2017

The issue is fixed properly for user's own account - no more timeouts. For built-in account the issue is fixed by detecting an error and requesting a new auth token automatically.

@yeriomin yeriomin closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants