-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material design [Request] #439
Comments
But without bumping minSdkVersion :-) (I would like) |
It seems to be something undergoing. It was spotted on #436 |
I would love this too! |
Download from XDA: https://labs.xda-developers.com/store/app/com.github.yeriomin.yalpstore |
Seems like work is going on...Cool.. |
@SciFi1818 @ale5000-git @Rikk @Leopard20 You can get a working prototype of a "material design" Yalp Store if you build the
Changes
So the main change is the drawer. I tried to rip its sources from the support library like I did with some other things, but it is too tightly coupled to the rest, so I would have to rewrite a lot of it or include half of it. So I just included it as the dependency. I'm planning to support both versions simultaneously so that newer devices would get the big "material design" version (if the device can run api>=14, it should not be a problem) and the old devices would get the small legacy version. If you want to try it, you can:
It is funny that this issue has appeared around the same time as #436 ... |
Here explain how to make Material Design apps compatible with API 8. Also there can be Also there is com.takisoft.fix:preference-v7 to fix problems of the official library. |
A bigger apk is not an issue for API 14 and up but might be an issue for API 8. And since API 5 has to be supported, it still wouldn't allow me to build just one version. The stackoverflow answer you linked is a bit old. The support library had different minsdk back then, so its not a trick, just an older support library.
This will make it build, and then crash... unless I test every feature on every device. This is very hacky.
com.android.support:preference-v7 is not used. Thank you for your input, but unless I reimplement the drawer from scratch, the support library with its minsdk will have to stay. Or am I missing something? |
@yeriomin do you need some feedback about the Plus version?
If you need screenshots I can post later, or if you are already aware of these things then okay. |
Sure.
You mean the launcher link? This means the installed apps page is displayed. It has no options menu, navigation moved to the drawer.
Either image or title should be displayed. Title fades in as you scroll bottom and hide the image. Are they displayed simultaneously?
What are your screen proportions? What is your device?
Is it a question? |
@yeriomin: Since at the end both versions will be stable, I think it could be better to publish them on F-Droid with 2 different internal names (something like com.github.yeriomin.yalpstore.legacy for the non-material version) (and also different external names) so both could co-exist on F-Droid on separate pages. Both should have update checks so putting them with different versions and same internal name could only confuse people and automatic update checks. |
Aurora (@ https://gitlab.com/AuroraOSS/AuroraStore renamed |
Their functionality will be identical, so I am planning to just build 2 apks with one package name. There will be no reason to use the legacy version for people with new devices, so they will automatically get the version with updated ui. I don't see a reason to make this an explicit choice. Like here: |
I personally like the simple style of the application. It just works. And quoting
Just my two cents, the application is good :) |
I dont see reson why we couldn't have material design because of 1% of old android users. Yalp store could be splitted into main app and legacy one for older devices. |
Having to maintain two applications is far from optimal or even desirable in my opinion… Even though it could work out easily with different builds, I guess. No idea how this works on F-Droid. |
@Lonami Thanks! It won't change much. Like I said, the only noticeable incompatibility with the material design guidelines is/was the navigation drawer. @Golbinex You didn't read the issue, did you? ;)
You can have anything you want, but I think UI should not be a priority. And most of it is material-design-compliant anyway already.
Because I started Yalp Store as a client for old devices. New devices work just fine with gapps, old devices don't. Yalp Store being open source is a secondary benefit.
See the discussion above. It is done already. Once enough feedback comes in to consider it stable, I'll add it to f-droid. |
Can an user switch from one version to another and vice-versa without lost data? I'm one of the rare users that mess continuously with the phone ;) |
Like with other apps: up but not down. Android does not allow updates with version code lower than the installed. And f-droid apks must have the same package name and different version codes to be considered the same app by f-droid. |
Yes, but you need to use 'pm' in command-line or adb. @yeriomin what do you need for debugging/fixing the title bar (black, white or dark) that overlaps the cover image? |
@Rikk Send me any feedback from the Yalp Store UI, mention your name or this issue number anywhere. Bug reports contain device info, recent logs. |
Android can downgrade while keep app data using |
is there material version of 0.42. |
I just saw a new app on f-droid which is a fork of Yalp with Material :)
https://f-droid.org/app/com.dragons.aurora
…On June 18, 2018 5:22:56 PM GMT+02:00, ***@***.*** wrote:
is there material version of 0.42.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#439 (comment)
--
Sent from my p≡p for Android.
|
@NitroNils Too bad the creator haven't provided a OTA zip file. I saw the issue but wish he would do it periodically, I could though but not sure how |
@TPS Just a heads-up. Aurora has moved its repository. |
@anunaym14 Fixed above, since @whyorean has clarified. |
Contemporary flavor can now be found on the github releases page. Built by travis-ci with every release. Next step - f-droid (if there are not too many bug reports). |
Sad, so material design is gonna be the default. Oh well, projects move forward. Thankfully this is a one-time application I don't run daily. |
@Lonami Don't worry.
Functionality is and will be the same for both versions. For the last 3-4 months I have been testing building both versions similtaneously and it works fine. I am not going to have to implement every feature twice. |
Time to close this. Please open new issues if something is wrong with the contemporary version, but not the legacy one. Or if you have any suggestions concerning the new UI. |
I don't know? Personally I am lost 😐 sorry |
A rebuild of the ui to Material Design would be awesome...
The text was updated successfully, but these errors were encountered: