Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS-455] Implement collections syntactic sugar #36

Merged
merged 34 commits into from
Feb 20, 2024
Merged

[PS-455] Implement collections syntactic sugar #36

merged 34 commits into from
Feb 20, 2024

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Feb 6, 2024 •
edited
Loading

Implement lists and blank node vectors for SPARQL triples, to address #32

This also involves the following auxilary work:

  • Rework triples-related AST structure
  • Rework the blank node validation to simplify it and support the reworked AST

@kelvinqian00
Add list specs
1939e32
@kelvinqian00
Add new triple/object and triple/list tags
3300d2f
@kelvinqian00
Distinguish spo-list from spo
016c663
@kelvinqian00
Move all triple and quad specs to triple ns
0e380bd
@kelvinqian00
Add :where/triple tag as a parallel to :where/special
5064279
@kelvinqian00
Rework blank node validation
7386127
@kelvinqian00
Extract out utility function and simplify bnode path construction
ad5b86f
@kelvinqian00
Add nform-list spec
2ef7aaf
@kelvinqian00
Fix nform specs and remove :triple/object
0b5b78f
@kelvinqian00
Remove :triple/object from format.triple tests
8604bcc
@kelvinqian00
Implement triple-vec-no-po and nform-no-po specs
f96cc07
@kelvinqian00
Remove :triple/object multimethod calls
d88c5a5
@kelvinqian00
Remove redundant :triple/nform kword
db6c170
@kelvinqian00
Replace :triple/vec with :triple.vec/spo
d1c35b2
@kelvinqian00
Replace :triple/quad keywords
7288e5b
@kelvinqian00
Add bracketted blank node blocks
239cf97
@kelvinqian00
Allow bnode ves to be nested in lists
abab618
@kelvinqian00
Add new macro to require-macros
a391461
@kelvinqian00
Use s/defs to avoid undefined function errors
0659153
@kelvinqian00
Add bnode-pair AST node and use objects as list entry specs
64a0443
@kelvinqian00
Undo the addition of :triple/bnode-pair
54e62ba
@kelvinqian00
Add tests
1b440eb
@kelvinqian00
Special case when po-pair vec is empty
9a24a5e
@kelvinqian00
Add tests and fix bnode bugs during validation
f2f2ecd
@kelvinqian00
Add end-to-end tests for new features
8600e7b
@kelvinqian00
Update docs with new features
a0310a3
@kelvinqian00
Special case for empty list
bd5d75b
@kelvinqian00
Allow combinations of empty and no-empty po-maps
1c36963
@kelvinqian00
Update comments
864e473
@kelvinqian00
Use subject-coll-nopath spec
62b2cef
@kelvinqian00 kelvinqian00 marked this pull request as ready for review February 7, 2024 16:33
@kelvinqian00 kelvinqian00 mentioned this pull request Feb 9, 2024
Merged
@kelvinqian00 kelvinqian00 merged commit ef98bf4 into main Feb 20, 2024
2 checks passed
@kelvinqian00 kelvinqian00 deleted the collections branch February 20, 2024 19:41
@kelvinqian00 kelvinqian00 mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invaliduser invaliduser invaliduser approved these changes

@milt milt milt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinqian00 @invaliduser @milt