Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL-258][SQL-259] Reaction UI bugfixes and enhancements #88

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Oct 1, 2024

Fix the following bugs in the reaction UI:

  • DOM nesting error due to nested <dl> elements
  • Condition values are sometimes erased when completing statement path selection
  • Statement path selector does not automatically offer new path segment after first changing the condition name
  • Cannot add array indexes without path input moving on to the next segment; this is fixed with new numeric input
  • Extensions paths are always marked as invalid despite actually being valid, preventing users from saving reactions with extension paths

In addition, perform the following enhancements:

  • New conditions are now added to the bottom instead of the top of the list
  • Typing used to be blocked when trying to input a duplicate condition name; this is now replaced with an error warning
  • Add additional :lang/get keywords in the text map, for new errors + form inputs

To do this, the following major refactors were made:

  • The reaction edit buffer spec now stores conditions as a vector instead of a map; this ensures stability when editing condition names
  • Major changes to the dropdown code, including removing code unused in lrs-admin-ui and adding the new numeric path segment input

@kelvinqian00 kelvinqian00 marked this pull request as ready for review October 2, 2024 14:02
@kelvinqian00 kelvinqian00 changed the title [SQL-258][SQL-259] Reaction UI bugfixes [SQL-258][SQL-259] Reaction UI bugfixes and enhancements Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant