upgrade activeadmin #674
Merged
upgrade activeadmin #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
upgrade_activeadmin
branch
2 times, most recently
from
4ca8428
to
af97db3
Compare
gigorok
reviewed
Apr 16, 2020
app/admin/system/disconnect_codes.rb
Outdated
| end | ||
| row('Silenly drop') do |r| | ||
| status_tag(r.silently_drop.to_s, r.silently_drop.to_s, class: r.silently_drop? ? :ok : :red) | ||
| status_tag(r.silently_drop.to_s, staclass: r.silently_drop? ? :ok : :red) |
Ivanov-Anton
force-pushed
the
upgrade_activeadmin
branch
from
af97db3
to
ac82341
Compare
|
Also solves issue number #570 |
|
@Ivanov-Anton seems it has regressions #885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit upgrade activeadmin
upgraded activeadmin from 1.4.3 to 2.7.0
casue of: outputting following warning
"
DEPRECATION WARNING: Active Admin: Theregister_stylesheetconfig is deprecated and will be removed in v2." link"
DEPRECATION WARNING: Active Admin: Thetypeparameter has been deprecated. Provide the "true" type as a class instead." linkremoved parameter named
typefrom all methods called status_tag