Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul Documentation #2321

Merged
merged 11 commits into from
Jan 5, 2022
Merged

Overhaul Documentation #2321

merged 11 commits into from
Jan 5, 2022

Conversation

ranile
Copy link
Member

@ranile ranile commented Jan 1, 2022

This PR:

  • Add introduction pages for category links
  • Reorganize docs
  • Removes duplicated and unneeded docs

Fixes part of #2312

@ranile ranile added this to the v0.20 milestone Jan 1, 2022
github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2022
View reviewed changes
@ranile ranile mentioned this pull request Jan 1, 2022
Open
19 tasks
github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 1, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3f06dcd):

https://yew-rs--pr2321-docs-overhaul-2w2sda7w.web.app

(expires Wed, 12 Jan 2022 14:36:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2022
View reviewed changes
This was referenced Jan 1, 2022
Closed
Open
@voidpumpkin
Copy link
Member

voidpumpkin commented Jan 3, 2022 •
edited
Loading

I haven't looked at this properly but in website build action there is a bunch of docosaurus warnings "Docs markdown link couldn't be resolved"

nvm they are in 0.18 versioned docs, i'll take a look at it separately

voidpumpkin
voidpumpkin requested changes Jan 3, 2022
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you touched 0.18 docs, can you also fix the links that the CI is warning about in "Build website" action?

website/docs/concepts/components/lifecycle.mdx Outdated Show resolved Hide resolved
website/docs/concepts/components/lifecycle.mdx Show resolved Hide resolved
website/docs/getting-started/build-a-sample-app.mdx Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2022
View reviewed changes
@ranile
Copy link
Member Author

ranile commented Jan 5, 2022

Can you confirm if the links are actually broken on the site as well? I checked and those paths seem to be correct. Not sure why there are warnings.

@ranile ranile enabled auto-merge (squash) January 5, 2022 14:31
voidpumpkin
voidpumpkin approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah those links do work. Weird...

@ranile ranile merged commit f6f0e34 into yewstack:master Jan 5, 2022
@voidpumpkin voidpumpkin mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@voidpumpkin voidpumpkin voidpumpkin approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@ranile @voidpumpkin