Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breaking changes section to changelog generator #3255

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Add breaking changes section to changelog generator #3255

merged 5 commits into from
Aug 18, 2023

Conversation

jellllly420
Copy link
Contributor

Description

Fixes #3212 by adding a new field is_breaking_change to LogLine struct.

New test of crate changelog designed.

Checklist

  • I have reviewed my own code
  • I have added tests

@futursolo futursolo added the A-tools Area: Tools such as trunk, wasm-bindgen label May 1, 2023
@jellllly420
Copy link
Contributor Author

friendly ping @voidpumpkin @futursolo
By the way, I found that both the old and current implementation handle name and homepage of commit author wrong. It should be fetched through Github API while we currently do it using git here. This inconsistency causes the problem. But if we switch to the right way, we are very likely to reach the limit of Github API.

ranile
ranile previously approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tools/changelog/tests/generate_yew_changelog_file.rs Outdated Show resolved Hide resolved
@ranile ranile requested a review from voidpumpkin June 1, 2023 12:06
github-actions[bot]
github-actions bot previously approved these changes Jun 1, 2023
View reviewed changes
@ranile
Copy link
Member

ranile commented Jun 1, 2023

Why did @github-actions approve this

@jellllly420
Copy link
Contributor Author

jellllly420 commented Jun 2, 2023 •
edited
Loading

@hamza1311 Sorry for my initial improper operation when committing your suggestion and this PR will still need your review. And it seems like there is something wrong with the Clippy auto check (See rust-lang/rust-clippy#10498).

@jellllly420 jellllly420 requested a review from ranile June 2, 2023 05:56
@ranile
Copy link
Member

ranile commented Jun 14, 2023

@jellllly420, can you merge (or rebase) the changes from master? The CI should be fixed with that

@jellllly420
Copy link
Contributor Author

@hamza1311 Sorry for the delay. It should be all right now.

ranile
ranile approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

cecton
cecton approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@cecton cecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@ranile ranile merged commit a27076d into yewstack:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranile ranile ranile approved these changes

@cecton cecton cecton approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@voidpumpkin voidpumpkin Awaiting requested review from voidpumpkin

Assignees
No one assigned
Labels
A-tools Area: Tools such as trunk, wasm-bindgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 🚨 Breaking changes section to changelog generator
4 participants
@jellllly420 @ranile @cecton @futursolo