Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

most_general method on subdivisions #52

Open
abigailfoster opened this issue Aug 20, 2019 · 1 comment
Open

most_general method on subdivisions #52

abigailfoster opened this issue Aug 20, 2019 · 1 comment

Comments

@abigailfoster
Copy link

We often need to know only the first subdivision, if any, returned by the lookup. I love that you've implemented a most_specific method so that it isn't necessary to guard for nil in that case. Would a most_general (or least_specific) method be a common enough use case to merge into the core project as well?

@yhirose
Copy link
Owner

yhirose commented Aug 21, 2019

@jamesfoster85, most_specific method is provided with the PR #31 by @f3ndot. I personally don't use the subdivision values. But if many people think the methods are common enough, I don't mind to accept a new pull request implementing them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants