Implement #most_specific method for result subdivisions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2017 14:59
Adds feature parity with the official Python client when accessing subdivisions. It will return the most specific (last) NamedLocation of the subdivisions array or an "empty" NamedLocation (to be consistent with Python client).
|
@f3ndot, the change looks great. thank you for your contribution! I have just bumped up the version to 0.1.15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature parity with the official Python client when accessing subdivisions.
It will return the most specific (last) NamedLocation of the subdivisions array or an "empty" NamedLocation (to be consistent with Python client) if no subdivisions available.
See the official Python library for reference: https://github.com/maxmind/GeoIP2-python/blob/04c8914d6445ed21c1df9bd1476153fd5c76ef36/geoip2/records.py#L444
Happy to return nil instead of an empty NamedLocation, whatever you think is best.