Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test precompiles ibc #4

Open
wants to merge 3 commits into
base: test-precompiles
Choose a base branch
from
Open

Test precompiles ibc #4

wants to merge 3 commits into from

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented Jul 22, 2022

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe force-pushed the test-precompiles-ibc branch 8 times, most recently from 0fe9774 to 047658e Compare July 28, 2022 09:16
mmsqe
mmsqe commented Jul 28, 2022
View reviewed changes
app/app.go Outdated
&app.TransferKeeper,
app.BankKeeper,
cronostypes.ModuleName,
"ibc/6411AE2ADA1E73DB59DB151A8988F9B7D5E7E233D8414DB6817F8F1A01611F86", // cronostypes.IbcCroDenomDefaultValue,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need hash by channel instead of hardcode

@mmsqe mmsqe marked this pull request as ready for review July 29, 2022 07:31
@mmsqe
test precompile ibc
1bffc9e 
append seq

fix ack fail due to receiver addr format

replace pending seq list with last seq

check has commit

rm blank import

revert test change

fix ibc go mismatch

print balances

fix sender

update pystarport

update ethermint

add get_ibc_cro_denom

pass strategy for test_ica with newer pystarport

without bump up hermes, for more info, see
	crypto-com/pystarport#63
	informalsystems/hermes#1571

test ack on timeout

check balance diff

handle hash ibc denom & ratio

clean up

fix link

handle revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmsqe