Version store #9
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| func (c *WebsocketClient) Close() { | ||
| if c.wsconn != nil { | ||
| c.wsconn.Close(websocket.StatusNormalClosure, "") |
Check warning
Code scanning / gosec
Errors unhandled.
| return nil, err | ||
| } | ||
| pairs = append(pairs, *pair) | ||
| offset += int(size) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| size, n := proto.DecodeVarint(data[offset:]) | ||
| offset += n | ||
| pair := new(types.StoreKVPair) | ||
| if err := proto.Unmarshal(data[offset:offset+int(size)], pair); err != nil { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| for k, _ := range finishedBlockNums { | ||
| if k <= blockNum { | ||
| delete(finishedBlockNums, k) | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
yihuang
force-pushed
the
version-store
branch
from
936cc90
to
7d1201a
Compare
| for _, storeKey := range keys { | ||
| exposeStoreKeys = append(exposeStoreKeys, storeKey) | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
| var bytes [8]byte | ||
| if _, err = io.ReadFull(f, bytes[:]); err == nil { | ||
| size := binary.BigEndian.Uint64(bytes[:]) | ||
| if info, err := f.Stat(); err == nil && size+uint64(8) == uint64(info.Size()) { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| }, | ||
| func(blockNum int) bool { | ||
| path := GetLocalDataFileName(directory, blockNum) | ||
| f, err := os.Open(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
| f, err := os.Open(path) | ||
| if err == nil { | ||
| defer func() { | ||
| _ = f.Close() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| offset := prefixLen | ||
| dataSize := sdk.BigEndianToUint64(data[:offset]) | ||
| size := len(data) | ||
| if int(dataSize)+prefixLen != size { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
instead of sync directly to db
subscribe latest blk via tm, sync historical via http
allow retry if incomplete
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)