fix #55: update the list of ports considered unsafe by Chrome (#56)

yihui · Aug 11, 2021 · 904832e · 904832e
1 parent 162215d
commit 904832e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # CHANGES IN servr VERSION 0.23
 
+- Updated the list of ports considered unsafe by Chrome (thanks, @RLesur, #56).
 
 # CHANGES IN servr VERSION 0.22
 

diff --git a/R/utils.R b/R/utils.R
@@ -173,7 +173,7 @@ serve_example = function(name, FUN, ..., run = interactive()) {
 #' @return A port number, or an error if no ports are available.
 random_port = function(port = 4321L, host = getOption('servr.host', '127.0.0.1'), n = 20) {
   # exclude ports considered unsafe by Chrome http://superuser.com/a/188070
-  ports = sample(setdiff(3000:8000, c(3659, 4045, 6000, 6665:6669)), n)
+  ports = sample(setdiff(3000:8000, c(3659, 4045, 5060, 5061, 6000, 6566, 6665:6669, 6697)), n)
   ports = c(port, ports)
   port = NULL
   # when a port has been used on 0.0.0.0, port_available() still returns TRUE