Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for db-oracle. #179

Merged
merged 22 commits into from
Jul 25, 2023
Merged

Add test for db-oracle. #179

merged 22 commits into from
Jul 25, 2023

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Jul 11, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Depends on release of https://github.com/yiisoft/db-oracle

@what-the-diff
Copy link

what-the-diff bot commented Jul 11, 2023

PR Summary

  • Added Workflow for Oracle-based tests
    We have included a new configuration file that allows us to run tests that require Oracle dependencies.

  • Adjusted Styling Rules
    The Styling rules file was altered to exclude a new Oracle-related file, as it's not relevant for style checks.

  • Included New Oracle Dependency
    We added a new Oracle package to the list of dependencies in our composer file. This package is needed for running all Oracle related operations.

  • Test suite for Oracle
    Our PHPUnit configuration now includes a suite for conducting Oracle-specific tests, enabling better integration.

  • Adapting Database Migration for Oracle
    The database migrator was adjusted to handle Oracle specific syntax for column definitions, ensuring smooth database migration when using Oracle.

  • Updated SQL Syntax in Tests for Oracle
    Several test files have been modified to support driver-specific SQL syntax for Oracle, providing reliable and accurate testing.

  • Added Oracle-specific Tests
    New test files specifically tailored for aspects related to Oracle database have been introduced, improving our test coverage significantly for Oracle databases.

  • Provided Factory Support for Oracle
    An Oracle factory class was created, offering methods to establish an Oracle database container for testing. It also includes function to clear the database after tests. Available methods have been replicated in Mssql and Mysql factory classes as well.

Remember, all these changes mean that we are now prepared to work with Oracle databases, including running our routine tests on them. All of this would lead to better software, providing us an edge as we can now broaden our clientele who use Oracle databases.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.34% ⚠️

Comparison is base (0f8926f) 81.32% compared to head (dcefe44) 80.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
- Coverage     81.32%   80.99%   -0.34%     
  Complexity      302      302              
============================================
  Files            37       37              
  Lines          1205     1205              
============================================
- Hits            980      976       -4     
- Misses          225      229       +4     
Files Changed Coverage Δ
src/Migrator.php 100.00% <ø> (ø)
src/Service/Generate/CreateService.php 100.00% <ø> (ø)
src/Service/MigrationService.php 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Migrator.php Outdated Show resolved Hide resolved
tests/Common/AbstractMigratorTest.php Outdated Show resolved Hide resolved
src/Migrator.php Outdated Show resolved Hide resolved
tests/Common/AbstractMigratorTest.php Outdated Show resolved Hide resolved
tests/Common/Command/AbstractListTablesCommandTest.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@terabytesoftw terabytesoftw marked this pull request as draft July 24, 2023 17:44
@terabytesoftw terabytesoftw marked this pull request as ready for review July 25, 2023 10:59
@terabytesoftw terabytesoftw merged commit 460dd10 into master Jul 25, 2023
148 of 149 checks passed
@terabytesoftw terabytesoftw deleted the add-test-oracle branch July 25, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants