Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTE query expressions #305

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Fix CTE query expressions #305

merged 2 commits into from
Oct 14, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 28, 2023

Update tests according to yiisoft/db#761

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • Introduction of New Testing Methods
    Two new test methods, testWithQuery and testWithQueryRecursive, have been introduced. These methods play a crucial role in checking the version of the database server. They will automatically bypass the tests should they encounter a database server version lower than 8.0.0. Such a feature will preserve system resources by preventing unnecessary testing with incompatible server versions.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6721db1) 99.09% compared to head (881de2e) 99.09%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #305   +/-   ##
=========================================
  Coverage     99.09%   99.09%           
  Complexity      184      184           
=========================================
  Files            13       13           
  Lines           552      552           
=========================================
  Hits            547      547           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 28, 2023 11:15
@Tigrov Tigrov merged commit 9e26690 into yiisoft:master Oct 14, 2023
39 of 40 checks passed
@Tigrov Tigrov deleted the fix-cte branch October 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants