Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename method ArrayDefinition::setReferenceContainer() to withReferenceContainer() and make him immutable #38

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Rename method ArrayDefinition::setReferenceContainer() to withReferenceContainer() and make him immutable #38

merged 2 commits into from
Jun 17, 2022

Conversation

vjik
Copy link
Member

@vjik vjik commented Jun 13, 2022 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues #30

Add support for yiisoft/definitions version ^2.0

Released packages

Non-released packages

Increase yiisoft/definitions version to ^2.0

Merge after new release of already released packages above.

@vjik vjik added the status:code review The pull request needs review. label Jun 13, 2022
@vjik vjik requested a review from a team June 13, 2022 11:19
samdark
samdark approved these changes Jun 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit f13ec09 into master Jun 17, 2022
@vjik vjik deleted the array-def-immutable branch June 17, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustamwin rustamwin rustamwin approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjik @samdark @rustamwin