Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the last semicolon for Yii asset/compress #61

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

tanakahisateru
Copy link

@tanakahisateru tanakahisateru commented Oct 5, 2017

Yii's asset/compress command cannot join JavaScripts they doesn't have semicolon at EOF correctly.

https://github.com/yiisoft/yii2/blob/1501c659aca7c50fa5e4f6fbe5ca549acc946c86/framework/console/controllers/AssetController.php#L571

So, I got these probrem with yii2-pjax 2.0.7:

no-semicolon

)(jQuery)
/*** END FILE: jquery.pjax.js ***/
/*** BEGIN FILE: yii.activeForm.js ***/
(function($){

Above would be compressed as:

)(jQuery)(function($){

I expect:

)(jQuery);(function($){

@samdark samdark merged commit 0d4cc3f into yiisoft:master Oct 5, 2017
@samdark
Copy link
Member

samdark commented Oct 5, 2017

Merged. Thanks!

@samdark samdark self-assigned this Oct 5, 2017
@samdark samdark modified the milestones: 2.0.7, 2.0.8 Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants