Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codecov config #94

Closed
wants to merge 2 commits into from
Closed

Add codecov config #94

wants to merge 2 commits into from

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@what-the-diff
Copy link

what-the-diff bot commented Jul 13, 2023

PR Summary

  • Introduction of Code Coverage Exclusions
    A new configuration file named codecov.yml was added. This file is going to help us refine our code coverage analysis by ignoring certain files that do not need to be tested. Notably, a file named rector.php will be excluded from this analysis.

  • File Renaming
    The file named infection.json.dist has been renamed to infection.json5.dist. This does not modify the file's functionality or contents but aligns with our naming conventions.

@arogachev arogachev requested a review from a team July 13, 2023 13:03
@arogachev arogachev self-assigned this Jul 13, 2023
@arogachev arogachev added the type:task Task label Jul 13, 2023
@arogachev arogachev changed the title Update configs Add codecov.yml config Jul 13, 2023
@arogachev arogachev changed the title Add codecov.yml config Add codecov config Jul 13, 2023
@vjik
Copy link
Member

vjik commented Jul 17, 2023

If coverage results that pass to codecov don't contain rector.php, then he is ignore. For example, code coverage yiisoft/html is 100% without ignore rector.php.

Therefore, ignore rector.php in PHPUnit tests is enough.

@arogachev arogachev closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arogachev arogachev

Labels
type:task Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arogachev @vjik