Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise the minimum PHP version #148

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Raise the minimum PHP version #148

merged 3 commits into from
Mar 25, 2022

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues #147

@rustamwin rustamwin requested a review from a team March 8, 2022 05:51
@rustamwin rustamwin added the status:code review The pull request needs review. label Mar 8, 2022
@vjik
Copy link
Member

vjik commented Mar 17, 2022

This change break backwards compatibility for already released package. What are the goals? Are there any other changes planned in the package?

@rustamwin
Copy link
Member Author

This change break backwards compatibility for already released package. What are the goals? Are there any other changes planned in the package?

Yes, this change can be tagged as major version.

@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:code review The pull request needs review. labels Mar 18, 2022
@vjik
Copy link
Member

vjik commented Mar 21, 2022

Maybe right away raise to 8.1?

@rustamwin
Copy link
Member Author

Maybe right away raise to 8.1?

We do not need 8.1 in this package yet. 8.0 also supports 8.1.

@vjik vjik merged commit dfdaadd into master Mar 25, 2022
@vjik vjik deleted the raise-php branch March 25, 2022 12:59
@rustamwin rustamwin linked an issue Apr 18, 2022 that may be closed by this pull request
Raise PHP version to 8.0 #147
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

@devanych devanych devanych approved these changes

@terabytesoftw terabytesoftw terabytesoftw approved these changes

Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise PHP version to 8.0
5 participants
@rustamwin @vjik @samdark @devanych @terabytesoftw