Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase server workers number #163

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Increase server workers number #163

merged 3 commits into from
Dec 4, 2022

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Dec 3, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

The webserver starts with two workers by default that allow to handle multiple request at the time.
❗ Doesn't work on Windows.

@xepozz xepozz added the status:code review The pull request needs review. label Dec 3, 2022
@xepozz xepozz requested a review from a team December 3, 2022 20:33
@what-the-diff
Copy link

what-the-diff bot commented Dec 3, 2022

  • Added a new option to the command line interface
  • Changed the way how PHP built-in web server is started (added workers number)

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 97.04% // Head: 97.09% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (5579193) compared to base (648b29b).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head 5579193 differs from pull request most recent head 9b49482. Consider uploading reports for the commit 9b49482 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #163      +/-   ##
============================================
+ Coverage     97.04%   97.09%   +0.05%     
  Complexity       64       64              
============================================
  Files             9        9              
  Lines           169      172       +3     
============================================
+ Hits            164      167       +3     
  Misses            5        5              
Impacted Files Coverage Δ
src/Command/Serve.php 95.16% <75.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark merged commit c0398b2 into master Dec 4, 2022
@samdark samdark deleted the increase_workers branch December 4, 2022 12:23
@samdark
Copy link
Member

samdark commented Dec 4, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants