Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use ErrorListiner without logger + Minor refactoring #194

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 7, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

After this PR need to create new issue: "Make logger in ErrorListener required, and remove event from package configuration"

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ac7fa6) 96.86% compared to head (5f2fceb) 96.48%.

Files Patch % Lines
src/ErrorListener.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     96.86%   96.48%   -0.38%     
+ Complexity       79       78       -1     
============================================
  Files             9        9              
  Lines           255      256       +1     
============================================
  Hits            247      247              
- Misses            8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 7, 2024

PR Summary

  • Improved Usage of ErrorListener
    An update to the product makes it possible to use the ErrorListener feature even when a logger is not available. This enhancement provides more flexibility as it caters for scenarios where the logger may not be necessary.

  • Enhanced ErrorListener Construction and Error Logging
    The mechanism through which the ErrorListener is constructed has been altered. Now, the system can cope with situations where the logging parameter is null. Furthermore, before logging an error, the system checks if the logger is null. This ensures we avoid complications that may arise from attempts to log without a logger.

@vjik vjik added the status:code review The pull request needs review. label Feb 7, 2024
@vjik vjik requested a review from a team February 7, 2024 11:21
@vjik vjik merged commit 8d5f767 into master Feb 8, 2024
24 of 30 checks passed
@vjik vjik deleted the move-event branch February 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants